Liveness probe is failing after upgrade to 0.58.0
After upgrading to 0.58.0, the liveness probes are failing with exit code 1.
Digging into the check-live
script, it fails at this line:
gitlab-runner verify -n $name -u $url 2>&1 | grep "alive"
Running it manually without grep, the output is:
Runtime platform arch=amd64 os=linux pid=58 revision=853330f9 version=16.5.0
WARNING: Running in user-mode.
WARNING: The user-mode requires you to manually start builds processing:
WARNING: $ gitlab-runner run
WARNING: Use sudo for system-mode:
WARNING: $ sudo gitlab-runner...
Verifying runner... is valid runner=REDACTED
According to the documentation for the verify
command and this script, the expected output is alive
, but the actual output is valid
.
Digging into the code, both seem to be valid. From that I've gathered, I believe is valid
is the output for the "new" style token manually created via the UI, while is alive
is the output for old style tokens. Both should probably be acceptable.
Edited by Christian