Helm pausing deployments is not working for operator updates
Summary
We observed this during the demo today. While doing the upgrade, kubernetes started rolling out a unicorn replicaset that should have been paused by helm. Our operator goes through and re-pauses these so it only got one pod up before it was paused, but we had added the pausing in helm as well to avoid these problems.
In https://gitlab.com/charts/gitlab/merge_requests/503#note_104128816 we had determined that for some reason helm was re-pausing these, but from our demo that looks to not be the case.
I just did some retesting, and it does not appear to work that way. (And instead works the way we originally thought, with helm not knowing to re-add the pause, if the operator was the one to unpause). I confirmed this by scaling my replicas on the operator to 0 on the demo cluster. (Also setting the operator to 0, in the local chart branch). And then updating using helm install. I can see that unicorn is not getting paused.