Documented `imagePullPolicy` for `gitlab.sidekiq.image` and `gitlab.unicorn.image` isn't correct
Summary
I discovered in https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/13111#note_173211230 that we're using the imagePullPolicy: IfNotPresent
Docker pull policy for the gitlab.sidekiq.image
and gitlab.unicorn.image
images even though https://gitlab.com/charts/gitlab/blob/master/doc/installation/command-line-options.md#advanced-gitlab-configuration states that the default policy is Always
, that's not the case when looking at the YAML config in Kubenertes, e.g.:
image: registry.gitlab.com/gitlab-org/build/cng-mirror/gitlab-sidekiq-ce:sh-bump-shoulda-matcher
imagePullPolicy: IfNotPresent
This is for the following merge request: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/28443.
Steps to reproduce
- Install GitLab and inspect the unicorn and/or Sidekiq pods' configuration.
Configuration used
This is happening in our Review Apps configured via https://gitlab.com/gitlab-org/gitlab-ce/blob/3846f89d4f9164e16313c11a78bdf9fa3ee2294e/scripts/review_apps/review-apps.sh#L210-243.
Current behavior
imagePullPolicy: IfNotPresent
Expected behavior
imagePullPolicy: Always
per the documentation at https://gitlab.com/charts/gitlab/blob/master/doc/installation/command-line-options.md#advanced-gitlab-configuration.
Versions
- Chart: latest version
- Platform:
- Kubernetes: (
kubectl version
)- Client Version:
version.Info{Major:"1", Minor:"14", GitVersion:"v1.14.1", GitCommit:"b7394102d6ef778017f2ca4046abbaa23b88c290", GitTreeState:"clean", BuildDate:"2019-04-19T22:12:47Z", GoVersion:"go1.12.4", Compiler:"gc", Platform:"darwin/amd64"}
- Server Version:
version.Info{Major:"1", Minor:"12+", GitVersion:"v1.12.7-gke.10", GitCommit:"8d9b8641e72cf7c96efa61421e87f96387242ba1", GitTreeState:"clean", BuildDate:"2019-04-12T22:59:24Z", GoVersion:"go1.10.8b4", Compiler:"gc", Platform:"linux/amd64"}
- Client Version:
- Helm: (
helm version
)- Client:
&version.Version{SemVer:"v2.13.1", GitCommit:"618447cbf203d147601b4b9bd7f8c37a5d39fbb4", GitTreeState:"clean"}
- Server:
&version.Version{SemVer:"v2.8.2", GitCommit:"a80231648a1473929271764b920a8e346f6de844", GitTreeState:"clean"}
- Client: