Sidekiq replicas not taken into account
Summary
Using the advanced sidekiq installation method, the replicas
key is not taken into account and doesn't appear to do anything.
Steps to reproduce
In an attempt to replicate GitLab.com, I wanted to see us spin up 20 replicas running specific queues. After applying the configuration below, I was left with only 1 Pod, and a matching HPA, none of which had my desired pod count of 20.
Configuration used
gitlab:
sidekiq:
pods:
- name: asap
concurrency: 8
replicas: 20
queues:
- [chat_notification, 1]
- [email_on_push, 1]
- [export_csv, 1]
- [mail_scheduler, 1]
- [new_note, 1]
- [post_recieve, 1]
- [project_cache, 1]
- [project_service, 1]
- [web_hook, 1]
Current behavior
% k get pods -n a -l app=sidekiq
NAME READY STATUS RESTARTS AGE
a-sidekiq-asap-6c97c89d8c-v95kx 1/1 Running 0 21m
a-sidekiq-besteffort-67546d96f8-4pccp 1/1 Running 1 21m
a-sidekiq-elasticsearch-968c57c99-5btgq 1/1 Running 1 21m
a-sidekiq-export-58fb5ffb5c-cc7jd 1/1 Running 0 21m
a-sidekiq-import-5c45bfbb4f-gmbdt 1/1 Running 1 21m
a-sidekiq-pages-56c948f9bf-frdss 1/1 Running 1 21m
a-sidekiq-pipeline-566c5c4485-gnszb 1/1 Running 1 21m
a-sidekiq-pullmirror-846b9cfd6b-t86s7 1/1 Running 0 21m
a-sidekiq-realtime-5696569df8-cxnld 0/1 Pending 0 21m
% k get hpa -n a -l app=sidekiq
NAME REFERENCE TARGETS MINPODS MAXPODS REPLICAS AGE
a-sidekiq-asap Deployment/a-sidekiq-asap <unknown>/350m 1 10 1 21m
a-sidekiq-besteffort Deployment/a-sidekiq-besteffort <unknown>/350m 1 10 1 21m
a-sidekiq-elasticsearch Deployment/a-sidekiq-elasticsearch <unknown>/350m 1 10 1 21m
a-sidekiq-export Deployment/a-sidekiq-export <unknown>/350m 1 10 1 21m
a-sidekiq-import Deployment/a-sidekiq-import <unknown>/350m 1 10 1 21m
a-sidekiq-pages Deployment/a-sidekiq-pages <unknown>/350m 1 10 1 21m
a-sidekiq-pipeline Deployment/a-sidekiq-pipeline <unknown>/350m 1 10 1 21m
a-sidekiq-pullmirror Deployment/a-sidekiq-pullmirror <unknown>/350m 1 10 1 21m
a-sidekiq-realtime Deployment/a-sidekiq-realtime <unknown>/350m 1 10 1 21m
Expected behavior
Sounds like we need to figure this out. I would immediately expect a setting of replicas: 20
to provide me 20 pods.
I would like to suggest that we add the attributes minReplicas
and maxReplicas
to each queue, and for each one to set the HPA appropriately.
Versions
- Chart:
cc07812060896a368da9df5bbf14dc8a835d58af
- Platform:
- Self-hosted: Minikube
- Kubernetes: (
kubectl version
)- Client:
1.14.7
- Server:
1.14.7
- Client:
- Helm: (
helm version
)- Client:
2.14.2
- Server: `2.14.2
- Client: