[gitlab/gitlab-exporter] Always mounts the redis secret
Summary
!1287 (merged) introduced a new way of providing Redis configurations, preventing disabling the password for an instance.
Steps to reproduce
Deploy GitLab with the following (providing just the relevant snippet):
redis:
host: w.x.y.z
password:
enabled: false
Current behavior
- the Redis secret is not created by the 'shared_secrets' subchart
- the deployed gitlab-exporter still attempts to mount the redis k8s secret
Expected behavior
- the gitlab-exporter deployment definition lacks the redis k8s secret mounts
- the gitlab-exporter successfully starts
Versions
- Chart: 3.3.1
- Platform:
- Cloud: GKE
- Kubernetes: (
kubectl version
)- Client: 1.15.0
- Server: 1.14.10-gke.32
- Helm: (
helm version
)- Client: 2.14.1
- Server: 2.15.1
Relevant logs
...
Warning FailedMount 7s (x60 over 106m) kubelet, gke-gitlab-gitlab-36733fba-7hll MountVolume.SetUp failed for volume "init-gitlab-exporter-secrets" : secret "gitlab-redis-secret" not found
Other
I've added a comment to the MR at !1287 (comment 331890747)