Upgrading to 5.5.0 throws the wrong error message when the task-runner chart wasn't renamed to toolbox
Summary
When upgrading to 5.5.0 and the gitlab.task-runner.backups
setting isn't renamed to gitlab.toolbox.backups
, then a confusing error message is thrown:
Error: UPGRADE FAILED: execution error at (gitlab/charts/gitlab/charts/toolbox/templates/deployment.yaml:227:23): A valid backups.objectStorage.config.secret is needed!
Renaming the values resolves the issue, but the error message should actually look something like this so that the problem is clear:
gitlab.task-runner:
The configuration of `gitlab.task-runner` has been renamed. Please use `gitlab.toolbox` instead.
This issue was identified by a customer.
Versions
- Chart: 5.5.0, GitLab 14.5.0