make check_mocks is not detecting missing mock file
A recent MR introduced internal/orka/Client.go
but did not generate new mocks. The build did not detect the missing internal/mocks/orka/Client.go
file through check_mocks
as it should because the target is defective:
current check_mocks
# Checking if mocks are up-to-date
# Removing existing mocks
# Generating new mocks
Generating mock for: CacheStore in file: mocks/providers/CacheStore.go
Generating mock for: Client in file: mocks/executors/winrm/Client.go
Generating mock for: Client in file: mocks/internal/orka/Client.go
Generating mock for: Encoder in file: mocks/internal/encoding/Encoder.go
Generating mock for: Env in file: mocks/internal/env/Env.go
Generating mock for: Executor in file: mocks/executors/Executor.go
Generating mock for: FS in file: mocks/internal/fs/FS.go
Generating mock for: Handler in file: mocks/internal/cli/Handler.go
Generating mock for: Logger in file: mocks/internal/logging/Logger.go
Generating mock for: Provider in file: mocks/providers/Provider.go
Generating mock for: Storage in file: mocks/internal/logging/storage/Storage.go
Generating mock for: customCommand in file: mocks/cmd/autoscaler/commands/custom/customCommand.go
Generating mock for: Client in file: internal/mocks/orka/Client.go
Generating mock for: Encoder in file: internal/mocks/encoding/Encoder.go
Generating mock for: Env in file: internal/mocks/env/Env.go
Generating mock for: FS in file: internal/mocks/fs/FS.go
Generating mock for: Handler in file: internal/mocks/cli/Handler.go
Generating mock for: Logger in file: internal/mocks/logging/Logger.go
Generating mock for: Storage in file: internal/mocks/logging/storage/Storage.go
# Checking the differences
make check_mocks 14.39s user 17.47s system 432% cpu 7.369 total
updated check_mocks
# Checking if mocks are up-to-date
# Removing existing mocks
# Generating new mocks
Generating mock for: CacheStore in file: mocks/providers/CacheStore.go
Generating mock for: Client in file: mocks/executors/winrm/Client.go
Generating mock for: Client in file: mocks/internal/orka/Client.go
Generating mock for: Encoder in file: mocks/internal/encoding/Encoder.go
Generating mock for: Env in file: mocks/internal/env/Env.go
Generating mock for: Executor in file: mocks/executors/Executor.go
Generating mock for: FS in file: mocks/internal/fs/FS.go
Generating mock for: Handler in file: mocks/internal/cli/Handler.go
Generating mock for: Logger in file: mocks/internal/logging/Logger.go
Generating mock for: Provider in file: mocks/providers/Provider.go
Generating mock for: Storage in file: mocks/internal/logging/storage/Storage.go
Generating mock for: customCommand in file: mocks/cmd/autoscaler/commands/custom/customCommand.go
Generating mock for: Client in file: internal/mocks/orka/Client.go
Generating mock for: Encoder in file: internal/mocks/encoding/Encoder.go
Generating mock for: Env in file: internal/mocks/env/Env.go
Generating mock for: FS in file: internal/mocks/fs/FS.go
Generating mock for: Handler in file: internal/mocks/cli/Handler.go
Generating mock for: Logger in file: internal/mocks/logging/Logger.go
Generating mock for: Storage in file: internal/mocks/logging/storage/Storage.go
# Checking the differences
Makefile | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
make: *** [check_mocks] Error 1
make check_mocks 14.28s user 17.77s system 430% cpu 7.444 total