Impossible to update a group variable from outside of a repository
Checklist
-
I'm using the latest version of the extension (Run glab --version
)- Extension version: v1.36.0
-
Operating system and version: Windows 10 -
Gitlab.com or self-managed instance? both -
GitLab version (if self-managed) 15.5.2 (Use the version
endpoint, like this: gitlab.my-company.com/api/v4/version) -
I have performed glab auth status
to check for authentication issues
Summary
It is not possible to update a group CI/CD variable from outside of a repository. It fails because it cannot found a .git/ folder in the hierarchy, but the informations from the .git folder are not used because we are updating the variable of a group.
Environment
- OS: Windows 10
- SHELL: git-bash
- TERM: Windows Terminal
- GLAB: v1.36.0
Other:
Steps to reproduce
$ glab variable set --group path/to/group MY_VARIABLE_KEY "the-value"
⇒ works as intended
$ glab variable update --group path/to/group MY_VARIABLE_KEY "the-value"
⇒ fails because not in a .git/ repository
What is the current bug behavior?
Failing because the git repository doesnt exists
What is the expected correct behavior?
Update the group variable.
Relevant logs and/or screenshots
Possible fixes
The check for the --group
option in the glab variable set
command is not in the same order : https://gitlab.com/gitlab-org/cli/-/blob/main/commands/variable/set/set.go?ref_type=heads#L107.
In the glab variable update
command, we try to get the BaseRepo whether the Group option is set or not, which does not seems correct : https://gitlab.com/gitlab-org/cli/-/blob/main/commands/variable/update/update.go?ref_type=heads#L111