Skip to content

global.ingress.annotations not applied into gitlab's minio ingress

Hi

I installed gitlab using operator by using yaml like this

apiVersion: apps.gitlab.com/v1beta1
kind: GitLab
metadata:
  name: example
spec:
  chart:
    version: "5.3.0" # select a version from the CHART_VERSIONS file in the root of this project
    values:
      global:
        hosts:
          domain: example.com
        ingress:
          configureCertmanager: true
      certmanager-issuer:
        email: youremail@example.com # use your real email address here

And then, I tried to update ingress annotation like this

apiVersion: apps.gitlab.com/v1beta1
kind: GitLab
metadata:
  name: example
spec:
  chart:
    version: "5.3.0" # select a version from the CHART_VERSIONS file in the root of this project
    values:
      global:
        hosts:
          domain: example.com
        ingress:
          configureCertmanager: true
          annotations:
            nginx.ingress.kubernetes.io/whitelist-source-range: 1.1.1.1
            nginx.ingress.kubernetes.io/enable-modsecurity: "true"
            nginx.ingress.kubernetes.io/enable-owasp-core-rules: "true"
            nginx.ingress.kubernetes.io/modsecurity-transaction-id: "$request_id"
      certmanager-issuer:
        email: youremail@example.com # use your real email address here

Four nginx ingress annotation can be applied by the operator into <name>-webservice-default and <name>-registry successfully, but there is no changes in <name>-minio

When I see to operator log, it seems that the operator only update 2 ingress object

2021-10-27T00:23:55.974Z        DEBUG   controllers.GitLab      Changing replica count of deployment with HPA   {"deployment": "gitlab-system/<name>-gitlab-shell", "replicas": 2}
2021-10-27T00:23:55.978Z        DEBUG   controllers.GitLab      Changing replica count of deployment with HPA   {"deployment": "gitlab-system/<name>-sidekiq-all-in-1-v1", "replicas": 1}
2021-10-27T00:23:55.981Z        DEBUG   controllers.GitLab      Changing replica count of deployment with HPA   {"deployment": "gitlab-system/<name>-registry", "replicas": 2}
W1027 00:23:56.106254       1 warnings.go:70] extensions/v1beta1 Ingress is deprecated in v1.14+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress
2021-10-27T00:23:56.106Z        DEBUG   controllers.GitLab      createOrPatch result    {"gitlab": "<name>.gitlab-system", "type": "*v1beta1.Ingress", "reference": "gitlab-system/<name>-registry", "result": "updated"}
W1027 00:23:56.133471       1 warnings.go:70] extensions/v1beta1 Ingress is deprecated in v1.14+, unavailable in v1.22+; use networking.k8s.io/v1 Ingress
2021-10-27T00:23:56.133Z        DEBUG   controllers.GitLab      createOrPatch result    {"gitlab": "<name>.gitlab-system", "type": "*v1beta1.Ingress", "reference": "gitlab-system/<name>-webservice-default", "result": "updated"}
2021-10-27T00:24:01.147Z        INFO    controllers.GitLab      Reconciling GitLab      {"gitlab": "gitlab-system/<name>"}
2021-10-27T00:24:01.148Z        DEBUG   controllers.GitLab      version information     {"gitlab": "gitlab-system/<name>", "upgrade": false, "current version": "5.3.0", "desired version": "5.3.0"}
W1027 00:24:01.316190       1 warnings.go:70] cert-manager.io/v1alpha2 Issuer is deprecated in v1.4+, unavailable in v1.6+; use cert-manager.io/v1 Issuer
2021-10-27T00:24:01.316Z        DEBUG   controllers.GitLab      createOrUpdate result   {"gitlab": "<name>.gitlab-system", "type": "*v1alpha2.Issuer", "reference": "gitlab-system/<name>-issuer", "result": "updated"}
2021-10-27T00:24:01.316Z        INFO    controllers.GitLab      running all migrations  {"gitlab": "gitlab-system/<name>"}

I expect that the minio ingress will also be updated like this code, but it doesn't https://gitlab.com/gitlab-org/charts/gitlab/-/blob/master/charts/minio/templates/ingress.yaml#L26