Remove NGINX Service LoadBalancerIP workaround
Summary
In !328 (a576cf27), we added a workaround that sets the NGINX Service Load Balancer IP to global.hosts.externalIP
(if set).
This restores original functionality that was mistakenly removed in gitlab-org/charts/gitlab!2267 (merged).
It's been fixed in the Chart itself in gitlab-org/charts/gitlab!2317 (merged), but is not part of Chart version 5.6.0. So when 5.6.1 is added to CHART_VERSIONS, we can remove that workaround.
Note: all CHART_VERSIONS need to be >= 5.6.1 before we revert the change. Alternatively, we can apply the workaround only if the chart version is < 5.6.1, but that's a bit more involved.
Acceptance criteria
-
Chart version 5.6.1 is added to CHART_VERSIONS (done automatically by Charts pipeline) -
All CHART_VERSIONS are >= 5.6.1 -
Workaround (!328 (a576cf27)) is reverted -
Confirm that NGINX Service external IP equals global.hosts.externalIP
without the workaround in place
Edited by Mitchell Nielsen