Skip to content

Fix review environment DNS labels

Clemens Beck requested to merge fix-ci-domain-name-system-labels-for-review-environments into master

What does this MR do?

Fix review environment DNS labels

Make sure that DNS labels do not exceed 63 characters. Invalid domain names can not be registered by external-dns, resulting in failed CI review jobs.

Closes: #1115 (closed)

Changelog: fixed

Checklist

See Definition of done.

For anything in this list which will not be completed, please provide a reason in the MR discussion.

Required

  • Merge Request Title and Description are up to date, accurate, and descriptive
  • MR targeting the appropriate branch
  • MR has a green pipeline on GitLab.com
  • When ready for review, MR is labeled "~workflow::ready for review" per the Distribution MR workflow

Expected (please provide an explanation if not completing)

  • Test plan indicating conditions for success has been posted and passes
  • Documentation created/updated
  • Tests added
  • Integration tests added to GitLab QA
  • Equivalent MR/issue for omnibus-gitlab opened
  • Validate potential values for new configuration settings. Formats such as integer 10, duration 10s, URI scheme://user:passwd@host:port may require quotation or other special handling when rendered in a template and written to a configuration file.

Related issues

Edited by Mitchell Nielsen

Merge request reports