ci: update automatic linting and fix issues
Context
The static-analysis
job runs the golangci-lint
linter. The job uses the old image registry.gitlab.com/gitlab-org/gitlab-build-images:golangci-lint-alpine
which was deprecated in %16.10.
Problem
The linter job has been silently failing because we have a condition set as -issues-exit-code 0
, for example https://gitlab.com/gitlab-org/container-registry/-/jobs/7380948519
Solution
-
Update the linter image to use the upstream version of golangci-lint
-
Make the static-analysis
pass on failure temporarilyallow_failure: true
-
Fix linting issues in small MRs to make reviews smaller and easy to follow -
Once all issues have been fixed, remove the allow_failure
flag from the job
Edited by Jaime Martinez