Skip to content

Improve Banner semgrep rule

We should also be able to detect:

`%div{class: "gl-banner"}` and `%div(class="gl-banner")`

The following discussion from !2 (merged) should be addressed:

  • @thutterer started a discussion: (+2 comments)

    @leipert Different to the banner regex, this doesn't look for a leading . so it also matches with %div{class: "gl-card"} and %div(class="gl-card"). See tests. Should we do the same for the banner?