Change: switch from scss-lint to stylelint
scss-lint
to stylelint
completely
Change pattern proposal: migrate from Old Pattern
scss-lint
is no longer actively maintained because the SCSS team switched to Dart. It does not support modern SCSS and CSS features, for instance, place-items
.
New Pattern
Stylelint is actively maintained and has better and up-to-date support for latest SCSS and CSS things.
Advantages of switching patterns
- Modern and up-to-date tool for linting SCSS.
- Faster CI pipeline because we have two tools for linting SCSS at the moment.
- We already have our SCSS configuration https://gitlab.com/gitlab-org/frontend/gitlab-stylelint-config.
- We can easily implement our own rules if required.
Disadvantages of switching patterns
- Zero?
What is the impact on our existing codebase?
- Like I mentioned above, a faster CI pipeline.
- Unified and one for linting SCSS.
Reference implementation
Here is the merge request with removed scss-lint
: gitlab-org/gitlab!39846 (closed)
Edited by Vitaly Slobodin