Conversation: CommitService::CommitStats

Gitlab::Git::CommitStats.new

---

Stages:

• RPC Design: gitaly-proto!39 (merged)

• Server Implementation: #480 (closed) !212 (merged)

• ~"Client Implementation": #519 (closed) https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/14077

• ~"Acceptance Testing": #539 (closed)

RPC Endpoints:

• Endpoint::Name

Known Client Routes:

• Known client endpoints

See Gitlab::Git::CommitStats.new

https://gitlab.com/gitlab-org/gitlab-ce/blob/40cd50829944db38fac07014e5fa00eafa3d1bc7/lib/gitlab/git/commit_stats.rb#L9-23

Gitlab::Git::CommitStats.new needs to change its signature so we can pass in a Gitlab::Git::Repository instance Gitlab::Git::CommitStats.new(repo, commit)

service CommitService {
  rpc CommitStats(CommitStatsRequest) returns (CommitStatsResponse) {}
}

message CommitStatsRequest {
  Repository repository = 1;
  bytes revision = 2;
}

message CommitStatsResponse {
  string oid = 1; // OID of the commit. Empty means not found.
  int32 additions = 2;
  int32 deletions = 3;
}

Current Status

This will be ported to Gitaly-Ruby and is blocked on the progress of that work stream.