Request leading to gitaly-git2go might fail during upgrade
Gitaly's libgit2
dependent operations run in a subprocess in order to support canceling the C calls. It could be that during the upgrade, the gitaly-git2go
binary on the disk is updated and called by an older gitaly
server. This could lead to errors if the calling interface has changed or undesired results if the request is interpreted a backwards incompatible manner. As an internal interface, ideally we wouldn't have to maintain a backwards compatible interface between the two binaries.
We should look in to our options to solve the issue, some options are pondered n the linked comment thread.
The following discussion from !2693 (merged) should be addressed:
-
@samihiltunen started a discussion: (+6 comments) We don't have to verify here again as
Run
already verifies the request beforegitaly-git2go
is executed.