[Feature Flag] Roll out user_create_branch_structured_errors
What
Enable the :user_create_branch_structured_errors
feature flag which will return structured errors for UserCreateBranch
.
Corresponding Gitaly MR: !4835 (diffs) Corresponding Gitlab MR: gitlab!96889 (merged) Issue: #4227 (closed)
Owners
- Team: Gitaly
- Most appropriate slack channel to reach out to:
#g_create_gitaly
- Best individual to reach out to: Karthik Nayak
Expectations
What release does this feature occur in first?
15.4
What are we expecting to happen?
UserCreateBranches
will use structured errors when we have an error with custom hooks.
What might happen if this goes wrong?
If the flag doesn't work, it'll fallback to old behavior, so this change is fairly safe.
What can we monitor to detect problems with this?
TODO
Roll Out Steps
-
Enable on staging -
Is the required code deployed on staging? (howto) -
Enable on staging (howto) -
Add featureflagstaging to this issue (howto) -
Test on staging (howto) -
Verify the feature flag was used by checking Prometheus metric gitaly_feature_flag_checks_total
-
-
Enable on production -
Is the required code deployed on production? (howto) -
Enable on production in #production
(howto) -
Add featureflagproduction to this issue -
Verify the feature flag was used by checking Prometheus metric gitaly_feature_flag_checks_total
-
-
Default-enable the feature flag (optional, only required if backwards-compatibility concerns exist) -
Wait for release containg default-disabled feature flag. -
Change the feature flag to default-enabled (howto) -
Wait for release containing default-enabled feature flag.
-
-
Remove feature flag
Please refer to the documentation of feature flags for further information.
Edited by Karthik Nayak