Skip to content

FindCommits does not wait for git-log(1) to finish, swallowing errors and logs

The FindCommits RPC uses git-log(1) to enumerate all commits that should be returned. But the logging process is never Wait()ed for. Thus, we wouldn't notice when git-log(1) returns an error. Furthermore, it results in us not correctly accounting for the runtime of this command in our log messages.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information