Follow-up from "Update CI job names and structure"

The following discussion from !2676 (merged) should be addressed:

@tigerwnz started a discussion: (+2 comments)

This job doesn't extend .rules:code-changes, which seems like a bug?

~~If we make yard extend code-changes too, we could move the extends: .rules:code-changes into the shared .test-job, and all of these visible jobs would only need one extend (.test-job).~~

Good spot! Looking at https://gitlab.com/gitlab-org/gitlab-development-kit/-/blob/main/.yardopts, yard also processes a few .md files in the root directory, so it needs to run for pretty much any change.

Looking at this job more closely too, we should move it out into the deploy stage as that's what the deploy:pages job needs. Will address in a follow-up MR 🙂