Timings for `gdk update` are confusing
Overview
When running a gdk update
, there are two sets of timings:
$ gdk update
--snip--
--------------------------------------------------------------------------------
Timings
--------------------------------------------------------------------------------
platform-update: 99 sec(s)
preflight-checks: 15 sec(s)
preflight-update-checks: 0 sec(s)
gitaly-update: 48 sec(s)
gitaly-git-pull: 3 sec(s)
gitlab-shell-update: 18 sec(s)
gitlab-shell-git-pull: 3 sec(s)
gitlab-update: 243 sec(s)
gitlab-git-pull: 30 sec(s)
gitlab-metrics-exporter-update: 7 sec(s)
gitlab-workhorse-update: 47 sec(s)
jaeger-update: 0 sec(s)
object-storage-update: 0 sec(s)
Took 486 sec(s) total.
--snip--
--------------------------------------------------------------------------------
Timings
--------------------------------------------------------------------------------
Took 10 sec(s) total.
--------------------------------------------------------------------------------
Reconfigured successfully as of 2023-03-29 15:29:09
--------------------------------------------------------------------------------
The reason for this is because 'under the covers', gdk update
runs the update logic followed by gdk reconfigure
which also produces another 'Timings' section.
Impacted categories
The following categories relate to this issue:
-
gdk-reliability - e.g. When a GDK action fails to complete. -
gdk-usability - e.g. Improvements or suggestions around how the GDK functions. -
gdk-performance - e.g. When a GDK action is slow or times out.
Proposal
We should only display a single 'Timings' section at the very bottom for gdk update
(as well as gdk reconfigure
and gdk install
).
Edited by Ash McKenzie