Geo: `gdk doctor` is throwing a warning when Geo is enabled in primary GDK
Overview
After !3387 (merged) in a primary GDK the geo
database is not set. The gdk doctor
diagnostic throws the following warning, even when Geo is enabled:
Geo
================================================================================
/Users/javieratapia/Desktop/gitlab-gdk/gdk/gitlab/config/database.yml contains the geo database settings but
geo.enabled is not set to true in your gdk.yml.
Either update your gdk.yml to set geo.enabled to true or remove
the geo database settings from /Users/javieratapia/Desktop/gitlab-gdk/gdk/gitlab/config/database.yml
https://gitlab.com/gitlab-org/gitlab-development-kit/blob/main/doc/howto/geo.md
Impacted categories
The following categories relate to this issue:
-
gdk-reliability - e.g. When a GDK action fails to complete. -
gdk-usability - e.g. Improvements or suggestions around how the GDK functions. -
gdk-performance - e.g. When a GDK action is slow or times out.
Steps to replicate (optional)
Enable Geo in a primary GDK and execute the gdk doctor
command
Proposal (optional)
Let's change the success?
logic in the Geo diagnostic class to validate if we are currently in a primary GDK. If that is the case, then we can skip the warning message.
Environment (optional)
- Operating system name:
<!-- output of `uname -a` command -->
- Architecture:
<!-- output of `arch` command -->
- The contents of your
gdk.yml
(if any) - Ruby version:
<!-- output of `ruby --version` command -->
- GDK version:
<!-- output of `git rev-parse --short HEAD` command -->
Edited by Javiera Tapia