Rename `add_users_into_project`
This is a weird name for this -- we never add things "into" projects, we just add them to projects. So how about we rename this to add_users_to_project
?
gitlab master % g grep 'into_projects'
app/models/members/project_member.rb:24: # add_users_into_projects(
app/models/members/project_member.rb:30: # add_users_into_projects(
app/models/members/project_member.rb:36: def add_users_into_projects(project_ids, user_ids, access, current_user = nil)
app/models/project_team.rb:37: ProjectMember.add_users_into_projects(
lib/tasks/gitlab/bulk_add_permission.rake:10: ProjectMember.add_users_into_projects(projects_ids, user_ids, ProjectMember::DEVELOPER)
lib/tasks/gitlab/bulk_add_permission.rake:13: ProjectMember.add_users_into_projects(projects_ids, admin_ids, ProjectMember::MASTER)
lib/tasks/gitlab/bulk_add_permission.rake:21: ProjectMember.add_users_into_projects(project_ids, Array.wrap(user.id), ProjectMember::DEVELOPER)
spec/models/members/project_member_spec.rb:104: describe '.add_users_into_projects' do
spec/models/members/project_member_spec.rb:112: ProjectMember.add_users_into_projects(