Spaces encode to %2520 instead of %20 on Gitlab URLs
~"bug"
Summary
https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CONTRIBUTING.md#feature-proposals
refers to a template for feature proposals at
https://gitlab.com/gitlab-org/gitlab-ce/blob/master/.gitlab/issue_templates/Feature%2520Proposal.md,
but this page leads to a 404. The space in the file name is encoded to %2520
instead of %20
in the URL.
Steps to reproduce
Write a link to a file with a space in its name. This bug is also reproduced when linking from here:
['Feature Proposal' issue template](.gitlab/issue_templates/Feature Proposal.md)
=>
'Feature Proposal' issue template
Expected behavior
Page should link to https://url.com/path/File%20Name.ext
Actual behavior
It replaces the space with %2520, resulting in https://url.com/path/File%2520Name.ext
According to this SO post, this might be a result of double encoding.
Possible fixes
- Easy fix: Avoid using spaces in file names. - and _ work without problems.
- Proper fix: This bug does not happen on the file hosted on Github, so I assume the issue lies in Gitlab's architecture. The SO post mentions bots double encoding URI, so I recommend to investigate in this direction first.