Branch show page?
I came across a 404 page in https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/28951931 which is giving me this link to the branch page:
https://gitlab.com/gitlab-org/gitlab-ce/branches/36089-handle-ref-failure-better
I don't think we have that page? Shouldn't this be:
https://gitlab.com/gitlab-org/gitlab-ce/commits/36089-handle-ref-failure-better
?
Looking at the code, it's:
= link_to "#{@build.pipeline.ref}", project_branch_path(@project, @build.pipeline.ref), class: 'link-commit'
And I don't think we should use project_branch_path
. Searching the codebase, we're also using it in MergeRequestPresenter#source_branch_path
, which we expose it to the API and some other JavaScript code.
Are they correct?