rake gitlab:shell:install creates ~git/.ssh/environment which gitlab:check complains about
Summary
Installing using the source install instructions, everything seems to go fine, but the gitlab:check task at the end complains because the git user has a custom ssh environment set.
Specifically it has a .ssh/environment file with a PATH override.
This .ssh/environment file was created during the install by runing bundle exec rake gitlab:shell:install
Steps to reproduce
Follow the instruction to install from source. Particularly, run bundle exec rake gitlab:shell:install and later bundle exec rake gitlab:check
What is the current bug behavior?
The check task fails with:
Git user has default SSH configuration? ... no
Try fixing it:
mkdir ~/gitlab-check-backup-1506436348
sudo mv /gitlab/gittest001/.ssh/environment ~/gitlab-check-backup-1506436348
For more information see:
doc/ssh/README.md in section "SSH on the GitLab server"
Please fix the error above and rerun the checks.
What is the expected correct behavior?
The check should succeed
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Current User: gittest001 Using RVM: no Ruby Version: 2.3.5p376 Gem Version: 2.5.2.1 Bundler Version:1.15.4 Rake Version: 12.0.0 Redis Version: 4.0.2 Git Version: 2.14.1 Sidekiq Version:5.0.4 Go Version: go1.9 linux/amd64GitLab information Version: 10.0.2 Revision: 06a5a331b4 Directory: /gitlab/gittest001/gitlab DB Adapter: postgresql URL: https://gittest001.hursley.ibm.com HTTP Clone URL: https://gittest001.hursley.ibm.com/some-group/some-project.git SSH Clone URL: gittest001@gittest001.hursley.ibm.com:some-group/some-project.git Using LDAP: yes Using Omniauth: no
GitLab Shell Version: 5.9.0 Repository storage paths:
- default: /gitlab/gittest001/repositories Hooks: /gitlab/gittest001/gitlab-shell/hooks Git: /usr/local/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab Shell ...GitLab Shell version >= 5.9.0 ? ... OK (5.9.0) Repo base directory exists? default... yes Repo storage directories are symlinks? default... no Repo paths owned by gittest001:root, or gittest001:gittest001? default... yes Repo paths access is drwxrws---? default... yes hooks directories in repos are links: ... can't check, you have no projects Running /gitlab/gittest001/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK
Access to /gitlab/gittest001/.ssh/authorized_keys: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Reply by email is disabled in config/gitlab.yml Checking LDAP ...
Server: ldapmain not verifying SSL hostname of LDAPS server 'ldap:636' LDAP authentication... Success LDAP users with access to your GitLab server (only showing the first 10 results) (filtered) Checking LDAP ... Finished
Checking GitLab ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... skipped (no tmp uploads folder yet) Init script exists? ... yes Init script up-to-date? ... yes Projects have namespace: ... can't check, you have no projects Redis version >= 2.8.0? ... yes Ruby version >= 2.3.3 ? ... yes (2.3.5) Git version >= 2.7.3 ? ... yes (2.14.1) Git user has default SSH configuration? ... no Try fixing it: mkdir ~/gitlab-check-backup-1506618400 sudo mv /gitlab/gittest001/.ssh/environment ~/gitlab-check-backup-1506618400 For more information see: doc/ssh/README.md in section "SSH on the GitLab server" Please fix the error above and rerun the checks. Active users: ... 8
Checking GitLab ... Finished
Possible fixes
I'm not sure which step is wrong - either the gitlab:shell:install rake task should not create .ssh/environment (around line 57 of lib/tasks/gitlab/shell.rake) or gitlab:check should allow it (in SystemCheck::App::GitUserDefaultSSHConfigCheck)