Banzai renders links to some uploads with absolute, rather than relative, URLs
Summary
This happens on project snippets, but seemingly not personal snippets. I've not audited any further than this.
Personal snippet description:
Foo
![41cde9052aaeb7e8](/uploads/-/system/personal_snippet/50/f26d2711c4421d460f7cf7eb9e3e3cb0/41cde9052aaeb7e8.jpg)
Personal snippet description_html:
<p dir="auto">Foo</p>
<p dir="auto"><a class="no-attachment-icon" href="/uploads/-/system/personal_snippet/50/f26d2711c4421d460f7cf7eb9e3e3cb0/41cde9052aaeb7e8.jpg" target="_blank" rel="noopener noreferrer"><img src="data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==" alt="41cde9052aaeb7e8" class="lazy" data-src="/uploads/-/system/personal_snippet/50/f26d2711c4421d460f7cf7eb9e3e3cb0/41cde9052aaeb7e8.jpg"></a></p>
Project snippet description:
test
![41cde9052aaeb7e8](/uploads/92637a4e47fcd6bbd08f0f59898984f8/41cde9052aaeb7e8.jpg)
Project snippet description_html:
<p dir="auto">test</p>
<p dir="auto"><a class="no-attachment-icon" href="http://localhost:4000/root/test-geo-log-cursor-5/uploads/92637a4e47fcd6bbd08f0f59898984f8/41cde9052aaeb7e8.jpg" target="_blank" rel="noopener noreferrer"><img src="data:image/gif;base64,R0lGODlhAQABAAAAACH5BAEKAAEALAAAAAABAAEAAAICTAEAOw==" alt="41cde9052aaeb7e8" class="lazy" data-src="http://localhost:4000/root/test-geo-log-cursor-5/uploads/92637a4e47fcd6bbd08f0f59898984f8/41cde9052aaeb7e8.jpg"></a></p>
This is a problem on Geo nodes, as the database cache is shared between them. So people browing the Geo secondary will find some of their requests going to the Geo primary. It's also a problem in non-geo context, though - it complicates changing hostname, etc.
Steps to reproduce
Create a project snippet with an attachment, view the HTML source
What is the current bug behavior?
Absolute URL is generated
What is the expected correct behavior?
Relative URL should be generated
Possible fixes
(If you can, link to the line of code that might be responsible for the problem)