Clicking cancel job on pipeline does not return the user to the return_to url
Summary
Clicking cancel job on the pipeline does not return the user to the return_to url but instead returns the user to the job detail page that was cancelled
Steps to reproduce
- Create a new pipeline build.
- Visit the Jobs (builds) page at
https://gitlab.com/.../pipelines/.../builds
- However over the [X] cancel button and notice the URL
https://gitlab.com/.../-/jobs/.../cancel?return_to=https%3A%2F%2Fgitlab.com...%2Fpipelines%2...%2Fbuilds
- Click the [X] cancel button.
What is the current bug behavior?
User is redirected to job detail page of the job that was cancelled at https://gitlab.com/idearoom/stanley/-/jobs/...
What is the expected correct behavior?
User is redirected to the return_to url or the builds page.
Relevant logs and/or screenshots
Output of checks
This bug happens on GitLab.com
Possible fixes
See https://gitlab.com/gitlab-org/gitlab-ce/blame/master/app/controllers/projects/jobs_controller.rb
Edited by Josh Unger