Disabling Pipelines for a project does not disable "Only allow merge requests to be merged if the pipeline succeeds"
Owners
UX: @dimitrieh FE: @lbennett BE: @matteeyah
Summary
I disabled the "Pipelines" feature on a project, which did not have any pipeline defined, but merge request setting "Only allow merge requests to be merged if the pipeline succeeds" was enabled.
After disabling the Pipelines feature, I was not able to merge any merge requests any more, because the setting "Only allow merge requests to be merged if the pipeline succeeds" apparently was still enforced.
The "Merge" button was disabled, showing the message "The pipeline for this merge request has not succeeded yet".
Steps to reproduce
- Create a project - Pipelines feature should be enabled by default. If it isn't, enable it but do not create any pipeline.
- Activate "Only allow merge requests to be merged if the pipeline succeeds" in "Merge request settings"
- Create a merge request for the project
- See that "Merge" button for the merge request is disabled with message "The pipeline for this merge request has not succeeded yet"
- In the project settings disable the Pipelines feature
Example Project
What is the current bug behavior?
"Merge" button remains disabled with message "The pipeline for this merge request has not succeeded yet"
What is the expected correct behavior?
When disabling the Pipelines feature, the setting "Only allow merge requests to be merged if the pipeline succeeds" should be automatically disabled as well, or at least not be enforced anymore.
Actually, maybe it would make sense to not enforce (enable) this setting at all as long as there are no pipelines defined for the project?
Relevant logs and/or screenshots
Output of checks
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Ubuntu 14.04 Current User: git Using RVM: no Ruby Version: 2.3.5p376 Gem Version: 2.6.13 Bundler Version:1.13.7 Rake Version: 12.0.0 Redis Version: 3.2.5 Git Version: 2.13.5 Sidekiq Version:5.0.4 Go Version: unknown
GitLab information Version: 10.0.3 Revision: 8895150 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql Using LDAP: yes Using Omniauth: no
GitLab Shell Version: 5.9.0 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab Shell ...GitLab Shell version >= 5.9.0 ? ... OK (5.9.0) Repo base directory exists? default... yes Repo storage directories are symlinks? default... no Repo paths owned by git:root, or git:git? default... yes Repo paths access is drwxrws---? default... yes hooks directories in repos are links: ... 9/7 ... ok 5/8 ... ok 5/9 ... ok 5/10 ... ok 5/11 ... ok 5/12 ... ok 5/13 ... ok 14/15 ... ok 5/16 ... ok 14/17 ... ok 20/18 ... ok 33/22 ... ok 14/23 ... ok 27/24 ... ok 29/25 ... ok 29/26 ... ok 29/27 ... ok 29/28 ... ok 5/29 ... ok 5/30 ... ok 5/31 ... ok 5/32 ... ok 5/33 ... ok 31/35 ... ok 29/36 ... ok 29/37 ... ok 29/38 ... ok 5/39 ... ok 5/40 ... ok 5/41 ... ok 34/42 ... ok 29/43 ... ok 5/45 ... ok 5/46 ... ok 5/48 ... ok 5/49 ... ok 5/50 ... ok 35/51 ... ok 35/52 ... ok 35/53 ... ok 35/54 ... ok 35/55 ... ok 35/56 ... ok 35/57 ... ok 35/58 ... ok 35/59 ... ok 5/60 ... ok 36/62 ... ok 36/63 ... ok 39/65 ... ok 41/67 ... ok 42/68 ... ok 41/69 ... ok 41/70 ... ok 17/71 ... repository is empty 42/72 ... ok 35/73 ... ok 41/74 ... ok 53/75 ... ok 53/76 ... ok 53/77 ... ok 35/78 ... ok 31/79 ... ok 42/81 ... ok 42/84 ... ok 43/85 ... ok 5/86 ... ok 42/88 ... ok 42/89 ... ok 35/90 ... ok 35/91 ... ok 5/92 ... ok 35/93 ... ok 35/94 ... ok 45/95 ... ok 31/96 ... ok 35/97 ... ok 14/98 ... ok 50/99 ... ok 51/102 ... ok 31/103 ... ok 52/104 ... ok 31/105 ... ok 52/106 ... ok 55/107 ... ok 55/108 ... ok 5/109 ... ok 42/110 ... ok 55/111 ... ok 31/112 ... ok 55/113 ... ok Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Reply by email is disabled in config/gitlab.yml Checking LDAP ...
Server: ldapmain LDAP authentication... Success LDAP users with access to your GitLab server (only showing the first 100 results)
Checking LDAP ... Finished
Checking GitLab ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 9/7 ... yes 5/8 ... yes 5/9 ... yes 5/10 ... yes 5/11 ... yes 5/12 ... yes 5/13 ... yes 14/15 ... yes 5/16 ... yes 14/17 ... yes 20/18 ... yes 33/22 ... yes 14/23 ... yes 27/24 ... yes 29/25 ... yes 29/26 ... yes 29/27 ... yes 29/28 ... yes 5/29 ... yes 5/30 ... yes 5/31 ... yes 5/32 ... yes 5/33 ... yes 31/35 ... yes 29/36 ... yes 29/37 ... yes 29/38 ... yes 5/39 ... yes 5/40 ... yes 5/41 ... yes 34/42 ... yes 29/43 ... yes 5/45 ... yes 5/46 ... yes 5/48 ... yes 5/49 ... yes 5/50 ... yes 35/51 ... yes 35/52 ... yes 35/53 ... yes 35/54 ... yes 35/55 ... yes 35/56 ... yes 35/57 ... yes 35/58 ... yes 35/59 ... yes 5/60 ... yes 36/62 ... yes 36/63 ... yes 39/65 ... yes 41/67 ... yes 42/68 ... yes 41/69 ... yes 41/70 ... yes 17/71 ... yes 42/72 ... yes 35/73 ... yes 41/74 ... yes 53/75 ... yes 53/76 ... yes 53/77 ... yes 35/78 ... yes 31/79 ... yes 42/81 ... yes 42/84 ... yes 43/85 ... yes 5/86 ... yes 42/88 ... yes 42/89 ... yes 35/90 ... yes 35/91 ... yes 5/92 ... yes 35/93 ... yes 35/94 ... yes 45/95 ... yes 31/96 ... yes 35/97 ... yes 14/98 ... yes 50/99 ... yes 51/102 ... yes 31/103 ... yes 52/104 ... yes 31/105 ... yes 52/106 ... yes 55/107 ... yes 55/108 ... yes 5/109 ... yes 42/110 ... yes 55/111 ... yes 31/112 ... yes 55/113 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.3.3 ? ... yes (2.3.5) Git version >= 2.7.3 ? ... yes (2.13.5) Git user has default SSH configuration? ... yes Active users: ... 28
Checking GitLab ... Finished
Possible fixes
Design
The copy change should be
Pipelines need to be configured for this feature to have an effect.
- Feature will always be visible (better discovery for the user)