Follow-up from "Fetch the merged branches at once in the `/projects/:id/repository/branches` endpoint"
The following discussion from !15215 (merged) should be addressed:
-
@DouweM started a discussion: (+7 comments)
If we have
pre_loaded_merged_branches
, do we need this check at all? If we don't, could we skip it, and even skiproot_ref_sha
?
Can we get [`git branch --merged`](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/lib/gitlab/git/repository.rb#L1216) to output the SHA along with the branch name? If so, we can easily filter out those that have a SHA matching the SHA of the root ref, which would only cost us one branch lookup.
I think it's as good think if
merged_branch_names
andmerged_to_root_ref?
both exclude branches that are equal to the root ref. Right now, the behaviour is kind of inconsistent.
And to answer to your question, making `git branch --merged` returning the SHA for the branches, I think yes we could! And that's really a good idea. This does the trick:
git branch --merged master --format='%(refname:short) %(objectname)' use-git-branch-merged use-rspec-support-helper
So it gave me:
use-rspec-support-helper bb5f79d43e0bb20bacd5ecd8b66832d9857bd079