"Frequently visited projects" section should save paths or IDs, not full URLs
On my local GDK instance, I had changed the gitlab hostname to run some tests and then changed it back afterword. I noticed after this that the link to one of my projects within the "Frequently visited" section was pointing to the old hostname.
Here's the contents of my localStorage <username>/frequent-projects
:
[
{
"id": 10,
"name": "test-project",
"namespace": "Administrator \/ test-project",
"webUrl": "http:\/\/localhost:3001\/root\/test-project",
"avatarUrl": null,
"lastAccessedOn": 1512413383024,
"frequency": 1
},
{
"id": 11,
"name": "hello-world",
"namespace": "Administrator \/ hello-world",
"webUrl": "http:\/\/10.0.1.7:3001\/root\/hello-world",
"avatarUrl": null,
"lastAccessedOn": 1512600148957,
"frequency": 10
}
]
This could be problematic if a user would ever change their hostname, move to a subdomain, switch on/off HTTPS, add a relative URL root path, etc. Perhaps we should store the project paths instead of full URLs?
/cc @kushalpandya (I think you worked on this, right?)
Edited by Eric Eastwood