Test to make sure there's no Ruby warnings
This is discovered by https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/3876 where we added a new test rake lint:static_verification
which would load the Rails application by Rails.application.eager_load!
, and then it emitted the following warnings:
/home/godfat/gitlab-ce/app/workers/concerns/project_import_options.rb:5: warning: already initialized constant ProjectImportOptions::IMPORT_RETRY_COUNT
/home/godfat/gitlab-ce/app/workers/concerns/project_import_options.rb:5: warning: previous definition of IMPORT_RETRY_COUNT was here
/home/godfat/gitlab-ce/lib/gitlab/database.rb:6: warning: already initialized constant Gitlab::Database::MAX_INT_VALUE
/home/godfat/gitlab-ce/lib/gitlab/database.rb:6: warning: previous definition of MAX_INT_VALUE was here
/home/godfat/gitlab-ce/lib/gitlab/database.rb:10: warning: already initialized constant Gitlab::Database::MAX_TIMESTAMP_VALUE
/home/godfat/gitlab-ce/lib/gitlab/database.rb:10: warning: previous definition of MAX_TIMESTAMP_VALUE was here
/home/godfat/gitlab-ce/lib/gitlab/database/migration_helpers.rb:4: warning: already initialized constant Gitlab::Database::MigrationHelpers::BACKGROUND_MIGRATION_BATCH_SIZE
/home/godfat/gitlab-ce/lib/gitlab/database/migration_helpers.rb:4: warning: previous definition of BACKGROUND_MIGRATION_BATCH_SIZE was here
/home/godfat/gitlab-ce/lib/gitlab/database/migration_helpers.rb:5: warning: already initialized constant Gitlab::Database::MigrationHelpers::BACKGROUND_MIGRATION_JOB_BUFFER_SIZE
/home/godfat/gitlab-ce/lib/gitlab/database/migration_helpers.rb:5: warning: previous definition of BACKGROUND_MIGRATION_JOB_BUFFER_SIZE was here
/home/godfat/gitlab-ce/lib/gitlab/redis/wrapper.rb:9: warning: already initialized constant Gitlab::Redis::Wrapper::DEFAULT_REDIS_URL
/home/godfat/gitlab-ce/lib/gitlab/redis/wrapper.rb:9: warning: previous definition of DEFAULT_REDIS_URL was here
/home/godfat/gitlab-ce/lib/gitlab/redis/wrapper.rb:10: warning: already initialized constant Gitlab::Redis::Wrapper::REDIS_CONFIG_ENV_VAR_NAME
/home/godfat/gitlab-ce/lib/gitlab/redis/wrapper.rb:10: warning: previous definition of REDIS_CONFIG_ENV_VAR_NAME was here
/home/godfat/gitlab-ce/lib/tasks/gitlab/task_helpers.rb:5: warning: already initialized constant Gitlab::TaskFailedError
/home/godfat/gitlab-ce/lib/tasks/gitlab/task_helpers.rb:5: warning: previous definition of TaskFailedError was here
/home/godfat/gitlab-ce/lib/tasks/gitlab/task_helpers.rb:6: warning: already initialized constant Gitlab::TaskAbortedByUserError
/home/godfat/gitlab-ce/lib/tasks/gitlab/task_helpers.rb:6: warning: previous definition of TaskAbortedByUserError was here
We should fix them and have a test which makes sure there's no warnings.
Edited by Lin Jen-Shin