Specifying asset host produces broken URL
Summary
A specified asset/CDN host make Gitlab produce incorrect URL.
Steps to reproduce
- specify
GITLAB_CDN_HOST
for asset compilation. - specify
GITLAB_CDN_HOST
for on unicorn start. - visit the dash board or any page.
What is the current bug behavior?
Specifying GITLAB_CDN_HOST
environment on both the unicorn server and the asset compilation makes Gitlab request slightly broken URL.
https://$GITLAB_CDN_HOST/javascripts/$GITLAB_CDN_HOST/assets/webpack/webpack_runtime.dec85f3f71ebac48e756.bundle.js
This requests are answered with 401.
What is the expected correct behavior?
The URL point to the correct asset:
https://$GITLAB_CDN_HOST/assets/webpack/webpack_runtime.dec85f3f71ebac48e756.bundle.js
Output of checks
(If you are reporting a bug on GitLab.com, write: This bug happens on GitLab.com)
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Debian 9.3 Current User: waldi Using RVM: no Ruby Version: 2.3.6p384 Gem Version: 2.5.2.1 Bundler Version:1.13.6 Rake Version: 12.3.0 Redis Version: 3.2.6 Git Version: 2.11.0 Sidekiq Version:5.0.4 Go Version: go1.9.2 linux/amd64GitLab information Version: 10.3.3 Revision: f4514c451a Directory: /home/waldi/gitlab DB Adapter: postgresql URL: https://salsa.debian.org HTTP Clone URL: https://salsa.debian.org/some-group/some-project.git SSH Clone URL: waldi@salsa.debian.org:some-group/some-project.git Using LDAP: no Using Omniauth: no
GitLab Shell Version: 5.10.2 Repository storage paths:
- default: /home/waldi/repositories Hooks: /home/waldi/gitlab-shell/hooks Git: /usr/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab Shell ...GitLab Shell version >= 5.10.2 ? ... OK (5.10.2) Repo base directory exists?
default... yes
Repo storage directories are symlinks?
default... no
Repo paths owned by waldi:root, or waldi:waldi? default... yes
Repo paths access is drwxrws---?
default... yes
hooks directories in repos are links: ... 1/1 ... ok
1/2 ... ok Running /home/waldi/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OKAccess to /home/waldi/.ssh/authorized_keys: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Reply by email is disabled in config/gitlab.yml Checking LDAP ...
LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... no Try fixing it: Install the init script For more information see: doc/install/installation.md in section "Install Init Script" Please fix the error above and rerun the checks. Init script up-to-date? ... can't check because of previous errors Projects have namespace: ... 1/1 ... yes 1/2 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.3.5 ? ... yes (2.3.6) Git version >= 2.7.3 ? ... yes (2.11.0) Git user has default SSH configuration? ... no Try fixing it: mkdir ~/gitlab-check-backup-1515953694 sudo mv /home/waldi/.ssh/environment ~/gitlab-check-backup-1515953694 sudo mv /home/waldi/.ssh/id_ed25519.pub ~/gitlab-check-backup-1515953694 sudo mv /home/waldi/.ssh/id_ed25519 ~/gitlab-check-backup-1515953694 For more information see: doc/ssh/README.md in section "SSH on the GitLab server" Please fix the error above and rerun the checks. Active users: ... 2
Checking GitLab ... Finished