Re-enable the `RSpec/SingleLineHook` cop
The issue is that the RSpec/SingleLineHook
cop currently inherits from RuboCop::Cop::Cop
while it should inherits from RuboCop::Cop::RSpec::Cop
(which filters out files that are not test files).
Currently, if we enable the cop we get offenses in non-test files, e.g.
lib/api/users.rb:444:11: C: RSpec/SingleLineHook: Don't use single-line hook blocks.
before { authenticated_as_admin! }
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TODO:
-
Fix gitlab-styles
: https://gitlab.com/gitlab-org/gitlab-styles/merge_requests/7 -
Update the gem in Gemfile.lock
and enable theRSpec/SingleLineHook
cop again: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/16704
Edited by Rémy Coutable