GitLab version number on help page is considered "commercial content"
Summary
On the Debian Salsa instance, no version number is shown for logged-in users. After looking into it, waldi on IRC found that the version number is hidden if the help_page_hide_commercial_content
flag is enabled.
Steps to reproduce
Create an account on the Debian Salsa instance and look at the Help page. No version number is shown.
What is the current bug behavior?
No version information or number is shown (e.g. it should say GitLab Community Edition 10.4.0).
What is the expected correct behavior?
On the GNOME instance you can see the version number on the help page (they don't have the flag enabled so some promotional info is also shown, the flag should only remove the promotional text, not the version info).
Possible fixes
Move the version info out of the commercial content check. https://gitlab.com/gitlab-org/gitlab-ce/blob/master/app/views/help/index.html.haml#L8