Confirmation modal of deleting protected branches does not validate input
Summary
Tl; dr: Confirmation modal to delete a protected branches does not validate branch name input.
Reproduced on Firefox 59.0.2 , Debian 9.4, the grey button visible on the following screenshot is clickable (but CSS link pointer is disabled)
Steps to reproduce
From the /branches
page of a project with a non-default protected branch. Click on the "trash" button to delete the branch.
A confirmation modal is shown. The modal asks to confirm the deletion with an input
field where you need to confirm the branch name.
The current modal does not validate the input and clicking on the (visually) disabled button sends the deletion request to the server.
What is the current bug behavior?
If input branch name
is wrong the "confirm" button can be clicked and deletes the branch.
What is the expected correct behavior?
If input branch name
is wrong the "confirm" button should not send the delete branch request to the server and you should keep seeing the modal.
Results of GitLab environment info
Reproduced on self-hosted gitlab instance:
> sudo gitlab-rake gitlab:env:info System information GitLab information Version: 10.5.6 Revision: 4b41d48 [...]
Issue is also reproducible on gitlab.com