[Rails5] -:push_events => true, +:push_events => false,
Note: add
rails5
to a branch name to trigger rails5 specific CI jobs.
https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/76050464
1) Admin::HooksController POST #create sets all parameters
Failure/Error: expect(SystemHook.first).to have_attributes(hook_params)
expected #<SystemHook id: 18, url: "http://example.com", project_id: nil, created_at: "2018-06-19 23:12:20", u...ues_events: false, repository_update_events: true, job_events: false, confidential_note_events: nil> to have attributes {:enable_ssl_verification => true, :token => "TEST TOKEN", :url => "http://example.com", :push_events => true, :tag_push_events => true, :repository_update_events => true, :merge_requests_events => true} but had attributes {:enable_ssl_verification => true, :token => "TEST TOKEN", :url => "http://example.com", :push_events => false, :tag_push_events => true, :repository_update_events => true, :merge_requests_events => true}
Diff:
@@ -1,6 +1,6 @@
:enable_ssl_verification => true,
:merge_requests_events => true,
-:push_events => true,
+:push_events => false,
:repository_update_events => true,
:tag_push_events => true,
:token => "TEST TOKEN",
# ./spec/controllers/admin/hooks_controller_spec.rb:27:in `block (3 levels) in <top (required)>'
Finished in 12 minutes 59 seconds (files took 24.88 seconds to load)
1233 examples, 1 failure, 2 pending