Node 6 and 7 compatibility broken by recent Monaco editor upgrade
When we added gitlab-org/gitlab-ce!17813 it introduced a plugin which inadvertently broke compatibility with any node version that doesn't understand the spread (...
) operator. This means that webpack can no longer compile in node v6.x and v7.x which we currently claim to support.
Removing this plugin would cause a lot of headaches, so for the moment I propose we either (or both):
- We suggest an upstream fix which removes node 6 incompatibilities in
monaco-editor-webpack-plugin
(it should be a simple fix) - We update our documentation to state that we only support node 8+
TL;DR for people encountering this issue
For now if you are unable to compile the gitlab assets, try upgrading to node 8.x or greater.
Edited by Mike Greiling