Reports Frontend plan
In order to make security reports UI components reusable between:
- The grouped section in MR widget for security reports
grouped_security_reports_app.vue
- Split section in pipeline's view for security reports
- Card section for security dashboard
- The grouped section in MR widget for test reports
- A future section in pipeline's view for test reports
🤷 (?) - still no mockups for this
We had to move the EE code into the CE codebase, however, the components still have too much logic and we now have a new problem, which is CE to EE conflicts. We also have 3 different deliverables by 3 different people in this release changing the same code, so we've had a call to work together:
Plan
Essential
-
@samdbeckham removed show all
link fromissues_list.vue
-
@filipa Move CSS to CE: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20696 & https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/6579 -
Create issue body component with new
badge for test reports -
@filipa create the Vuex Store for the reports: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/20709 -
...
Nice to have
-
On the 6th or 7th - after we've merged 11.2 deliverables and before we start 11.3, move all components under vue_shared/components/reports
toreports/components
-
Remove sastContainer
logic fromissues_list.vue
, provide a prop instead -
Rename CSS classes to not say security
-
Create a common file in CE for constants LOADING, SUCCESS, ERROR
or find a way for the components to not need them -
Could we have report_issues.vue
dumb enough not to know about each type of issue? Maybe have this logic as a map elsewhere? (Like we do for some parts of the MR widget) -
...
Future
-
Move help_popover outside of the reports section [CE]: https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/21011 -
Handle the CE to EE difference in .vue
components - todo @filipa link the issue with this discussion here -
...
Edited by Filipa Lacerda