Save (Update) a Wiki Page gives 500
Summary
After upgrading self hosted Gitlab CE to latest 11.1 editing a wiki page gives a 500 error. Changes to the Wiki page are saved - but no redirect to updated page happens instead gitlab shows 500 error.
Steps to reproduce
Edit existing Wiki page and hit save - gitlab shows 500. Still the same after gitlab-ctl restart - the error still exists.
What is the expected correct behavior?
Should redirect to edited page (as before upgrade)
Relevant logs and/or screenshots
Started PUT "/amazone/spreaddb/spreaddb-ui/wikis/2018-07-Release-1.0.0-alpha-todos" for 46.23.213.1 at 2018-07-23 15:34:29 +0200
Processing by Gitlab::RequestForgeryProtection::Controller#index as HTML
Parameters: {"utf8"=>"✓", "authenticity_token"=>"[FILTERED]", "wiki"=>{"last_commit_sha"=>"e44ba802ed434f32c67ae96325c611fecae48738", "title"=>"2018 07 Release 1.0.0 alpha todos", "format"=>"markdown", "content"=>"[FILTERED]", "message"=>"Update 2018 07 Release 1.0.0 alpha todos"}}
Completed 200 OK in 1ms (ActiveRecord: 0.0ms)
Processing by Projects::WikisController#update as HTML
Parameters: {"utf8"=>"✓", "authenticity_token"=>"[FILTERED]", "wiki"=>{"last_commit_sha"=>"e44ba802ed434f32c67ae96325c611fecae48738", "title"=>"2018 07 Release 1.0.0 alpha todos", "format"=>"markdown", "content"=>"[FILTERED]", "message"=>"Update 2018 07 Release 1.0.0 alpha todos"}, "namespace_id"=>"amazone/spreaddb", "project_id"=>"spreaddb-ui", "id"=>"2018-07-Release-1.0.0-alpha-todos"}
Started POST "/api/v4/internal/allowed" for 127.0.0.1 at 2018-07-23 15:34:29 +0200
Processing by Gitlab::RequestForgeryProtection::Controller#index as */*
Parameters: {"changes"=>"e44ba802ed434f32c67ae96325c611fecae48738 aa8645ff8d0ceb04b91159c56328b03be9d8e07d refs/heads/master\n", "gl_repository"=>"wiki-32", "project"=>"/var/opt/gitlab/git-data/repositories/amazone/spreaddb/spreaddb-ui.wiki.git", "protocol"=>"web", "env"=>"{\"GIT_ALTERNATE_OBJECT_DIRECTORIES\":[],\"GIT_ALTERNATE_OBJECT_DIRECTORIES_RELATIVE\":[],\"GIT_OBJECT_DIRECTORY\":null,\"GIT_OBJECT_DIRECTORY_RELATIVE\":null}", "user_id"=>"2", "secret_token"=>"[FILTERED]"}
Can't verify CSRF token authenticity
This CSRF token verification failure is handled internally by `GitLab::RequestForgeryProtection`
Unlike the logs may suggest, this does not result in an actual 422 response to the user
For API requests, the only effect is that `current_user` will be `nil` for the duration of the request
Completed 422 Unprocessable Entity in 1ms (ActiveRecord: 0.0ms)
Started POST "/api/v4/internal/pre_receive" for 127.0.0.1 at 2018-07-23 15:34:29 +0200
Processing by Gitlab::RequestForgeryProtection::Controller#index as */*
Parameters: {"gl_repository"=>"wiki-32", "secret_token"=>"[FILTERED]"}
Can't verify CSRF token authenticity
This CSRF token verification failure is handled internally by `GitLab::RequestForgeryProtection`
Unlike the logs may suggest, this does not result in an actual 422 response to the user
For API requests, the only effect is that `current_user` will be `nil` for the duration of the request
Completed 422 Unprocessable Entity in 1ms (ActiveRecord: 0.0ms)
Started POST "/api/v4/internal/post_receive" for 127.0.0.1 at 2018-07-23 15:34:29 +0200
Processing by Gitlab::RequestForgeryProtection::Controller#index as */*
Parameters: {"gl_repository"=>"wiki-32", "identifier"=>"user-2", "changes"=>"e44ba802ed434f32c67ae96325c611fecae48738 aa8645ff8d0ceb04b91159c56328b03be9d8e07d refs/heads/master\n", "secret_token"=>"[FILTERED]"}
Can't verify CSRF token authenticity
This CSRF token verification failure is handled internally by `GitLab::RequestForgeryProtection`
Unlike the logs may suggest, this does not result in an actual 422 response to the user
For API requests, the only effect is that `current_user` will be `nil` for the duration of the request
Completed 422 Unprocessable Entity in 1ms (ActiveRecord: 0.0ms)
Completed 500 Internal Server Error in 1055ms (ActiveRecord: 11.7ms)
Encoding::UndefinedConversionError ("\xC3" from ASCII-8BIT to UTF-8):
config/initializers/forbid_sidekiq_in_transactions.rb:35:in `block (2 levels) in <module:NoEnqueueingFromTransactions>'
app/models/service.rb:237:in `async_execute'
app/models/project.rb:1133:in `block (2 levels) in execute_services'
app/models/project.rb:1132:in `block in execute_services'
lib/after_commit_queue.rb:27:in `instance_eval'
lib/after_commit_queue.rb:27:in `run_after_commit_or_now'
app/models/project.rb:1131:in `execute_services'
app/services/wiki_pages/base_service.rb:8:in `execute_hooks'
lib/gitlab/metrics/instrumentation.rb:159:in `block in execute_hooks'
lib/gitlab/metrics/method_call.rb:36:in `measure'
lib/gitlab/metrics/instrumentation.rb:159:in `execute_hooks'
app/services/wiki_pages/update_service.rb:5:in `execute'
lib/gitlab/metrics/instrumentation.rb:159:in `block in execute'
lib/gitlab/metrics/method_call.rb:36:in `measure'
lib/gitlab/metrics/instrumentation.rb:159:in `execute'
app/controllers/projects/wikis_controller.rb:48:in `update'
lib/gitlab/i18n.rb:51:in `with_locale'
lib/gitlab/i18n.rb:57:in `with_user_locale'
app/controllers/application_controller.rb:362:in `set_locale'
lib/gitlab/middleware/multipart.rb:97:in `call'
lib/gitlab/request_profiler/middleware.rb:14:in `call'
lib/gitlab/middleware/go.rb:17:in `call'
lib/gitlab/etag_caching/middleware.rb:11:in `call'
lib/gitlab/middleware/rails_queue_duration.rb:22:in `call'
lib/gitlab/metrics/rack_middleware.rb:15:in `block in call'
lib/gitlab/metrics/transaction.rb:53:in `run'
lib/gitlab/metrics/rack_middleware.rb:15:in `call'
lib/gitlab/middleware/read_only/controller.rb:38:in `call'
lib/gitlab/middleware/read_only.rb:16:in `call'
lib/gitlab/request_context.rb:18:in `call'
lib/gitlab/metrics/requests_rack_middleware.rb:27:in `call'
lib/gitlab/middleware/release_env.rb:10:in `call'
Results of GitLab environment info
>> gitlab-rake gitlab:env:infoSystem information System: Ubuntu 16.04 Current User: git Using RVM: no Ruby Version: 2.4.4p296 Gem Version: 2.7.6 Bundler Version:1.16.2 Rake Version: 12.3.1 Redis Version: 3.2.11 Git Version: 2.17.1 Sidekiq Version:5.1.3 Go Version: unknown
GitLab information Version: 11.1.0 Revision: 35c387c Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql URL: XXX HTTP Clone URL: XXX SSH Clone URL: XXX Using LDAP: no Using Omniauth: no
GitLab Shell Version: 7.1.4 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
gitlab-rake gitlab:check SANITIZE=true Checking GitLab Shell ...GitLab Shell version >= 7.1.4 ? ... OK (7.1.4) Repo base directory exists? default... yes Repo storage directories are symlinks? default... no Repo paths owned by git:root, or git:git? default... yes Repo paths access is drwxrws---? default... yes hooks directories in repos are links: ... 7/2 ... ok 7/3 ... ok 7/4 ... ok 7/5 ... ok 7/6 ... ok 7/7 ... ok 7/8 ... ok 7/9 ... ok 7/10 ... ok 7/11 ... ok 7/12 ... ok 7/13 ... ok 2/14 ... ok 2/15 ... ok 2/16 ... ok 7/18 ... ok 7/19 ... ok 7/20 ... ok 7/21 ... ok 2/22 ... repository is empty 16/25 ... ok 18/26 ... ok 18/27 ... ok 13/28 ... ok 18/29 ... ok 18/30 ... ok 18/31 ... repository is empty 7/32 ... ok 18/33 ... ok 20/34 ... ok 21/35 ... ok 7/36 ... ok Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Reply by email ...
IMAP server credentials are correct? ... yes
Init.d configured correctly? ... skipped MailRoom running? ... skipped
Checking Reply by email ... Finished
Checking LDAP ...
LDAP is disabled in config/gitlab.yml
Checking LDAP ... Finished
Checking GitLab ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 7/2 ... yes 7/3 ... yes 7/4 ... yes 7/5 ... yes 7/6 ... yes 7/7 ... yes 7/8 ... yes 7/9 ... yes 7/10 ... yes 7/11 ... yes 7/12 ... yes 7/13 ... yes 2/14 ... yes 2/15 ... yes 2/16 ... yes 7/18 ... yes 7/19 ... yes 7/20 ... yes 7/21 ... yes 2/22 ... yes 16/25 ... yes 18/26 ... yes 18/27 ... yes 13/28 ... yes 18/29 ... yes 18/30 ... yes 18/31 ... yes 7/32 ... yes 18/33 ... yes 20/34 ... yes 21/35 ... yes 7/36 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.3.5 ? ... yes (2.4.4) Git version >= 2.9.5 ? ... yes (2.17.1) Git user has default SSH configuration? ... yes Active users: ... 10
Checking GitLab ... Finished