Group avatar upload issue
Summary
When users attempt to upload a group avatar, we simply get error 500. This started happening after upgrading to 11.1 and persists in 11.1.1; we have not changed anything relating to storage paths.
Steps to reproduce
- Go to the Group Settings page
- Upload Avatar under "General"
- Click Upload
I was unable to reproduce this on gitlab.com, so there is something wrong with our instance more than likely - but we're not sure what. We use local storage as we don't have an Enterprise license at this time, leaving us unable (as far as I know) to use Object Storage for file uploads.
Let me know if additional details are required.
What is the current bug behavior?
Avatar does not upload, produces error 500.
What is the expected correct behavior?
Avatar uploads correctly.
Relevant logs and/or screenshots
UploadedFile::InvalidPathError (insecure path used '/var/opt/gitlab/gitlab-rails/uploads/tmp/herh.jpg347505125'):
lib/uploaded_file.rb:42:in `from_params'
lib/gitlab/middleware/multipart.rb:85:in `open_file'
lib/gitlab/middleware/multipart.rb:73:in `decorate_params_value'
lib/gitlab/middleware/multipart.rb:48:in `block in with_open_files'
lib/gitlab/middleware/multipart.rb:39:in `each'
lib/gitlab/middleware/multipart.rb:39:in `with_open_files'
lib/gitlab/middleware/multipart.rb:101:in `call'
lib/gitlab/request_profiler/middleware.rb:14:in `call'
ee/lib/gitlab/jira/middleware.rb:15:in `call'
lib/gitlab/middleware/go.rb:17:in `call'
lib/gitlab/etag_caching/middleware.rb:11:in `call'
lib/gitlab/middleware/rails_queue_duration.rb:22:in `call'
lib/gitlab/metrics/rack_middleware.rb:15:in `block in call'
lib/gitlab/metrics/transaction.rb:53:in `run'
lib/gitlab/metrics/rack_middleware.rb:15:in `call'
lib/gitlab/middleware/read_only/controller.rb:38:in `call'
lib/gitlab/middleware/read_only.rb:16:in `call'
lib/gitlab/request_context.rb:18:in `call'
lib/gitlab/metrics/requests_rack_middleware.rb:27:in `call'
lib/gitlab/middleware/release_env.rb:10:in `call'
Output of checks
Private, on-premise installation.
Results of GitLab environment info
Expand for output related to GitLab environment info
System information System: Proxy: no Current User: git Using RVM: no Ruby Version: 2.4.4p296 Gem Version: 2.7.6 Bundler Version:1.16.2 Rake Version: 12.3.1 Redis Version: 3.2.11 Git Version: 2.17.1 Sidekiq Version:5.1.3 Go Version: unknownGitLab information Version: 11.1.1-ee Revision: 69fdb75 Directory: /opt/gitlab/embedded/service/gitlab-rails DB Adapter: postgresql DB Version: 9.6.8 URL: https://gitlab.removed.com HTTP Clone URL: https://gitlab.removed.com/some-group/some-project.git SSH Clone URL: git@gitlab.removed.com:some-group/some-project.git Elasticsearch: no Geo: no Using LDAP: yes Using Omniauth: yes Omniauth Providers: azure_oauth2
GitLab Shell Version: 7.1.4 Repository storage paths:
- default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git
Results of GitLab application Check
Expand for output related to the GitLab application check
Checking GitLab Shell ...GitLab Shell version >= 7.1.4 ? ... OK (7.1.4) Repo base directory exists? default... yes Repo storage directories are symlinks? default... no Repo paths owned by git:root, or git:git? default... yes Repo paths access is drwxrws---? default... yes hooks directories in repos are links: ... 7/1 ... repository is empty 7/2 ... repository is empty 7/3 ... repository is empty 7/4 ... repository is empty 68/5 ... ok 7/6 ... repository is empty 6/7 ... ok 6/8 ... repository is empty 10/9 ... repository is empty 9/10 ... ok 19/11 ... repository is empty 114/13 ... repository is empty 13/14 ... repository is empty 39/15 ... ok 6/16 ... ok 6/17 ... repository is empty 2/18 ... repository is empty 19/21 ... repository is empty 7/22 ... repository is empty 100/23 ... ok 100/24 ... ok 100/25 ... ok 100/26 ... ok 100/27 ... ok 99/28 ... ok 100/29 ... ok 100/30 ... ok 21/31 ... repository is empty 21/32 ... repository is empty 21/33 ... repository is empty 6/34 ... repository is empty 6/35 ... repository is empty 24/36 ... ok 21/37 ... ok 20/38 ... ok 23/39 ... ok 23/40 ... ok 2/43 ... repository is empty 2/44 ... ok 10/45 ... ok 2/46 ... ok 12/47 ... repository is empty 25/48 ... repository is empty 25/49 ... repository is empty 26/50 ... repository is empty 26/51 ... repository is empty 6/52 ... repository is empty 2/53 ... repository is empty 2/54 ... repository is empty 34/56 ... ok 38/58 ... ok 39/59 ... ok 34/63 ... ok 37/64 ... repository is empty 49/66 ... ok 2/67 ... repository is empty 7/68 ... repository is empty 12/69 ... repository is empty 51/70 ... ok 51/71 ... ok 34/72 ... ok 6/73 ... repository is empty 4/76 ... repository is empty 60/78 ... ok 6/79 ... ok 39/80 ... ok 2/81 ... ok 62/82 ... ok 26/83 ... repository is empty 51/84 ... ok 96/85 ... ok 62/86 ... ok 43/87 ... ok 60/88 ... ok 64/89 ... ok 8/90 ... ok 8/92 ... ok 8/93 ... ok 24/94 ... ok 54/95 ... ok 15/96 ... ok 96/97 ... ok 60/99 ... ok 99/102 ... ok 62/103 ... ok 60/105 ... ok 60/106 ... ok 39/107 ... ok 57/108 ... ok 77/109 ... ok 99/110 ... ok 43/112 ... ok 43/113 ... ok 84/115 ... ok 81/116 ... ok 88/119 ... ok 88/120 ... ok 24/121 ... repository is empty 24/122 ... ok 77/123 ... ok 14/124 ... ok 39/125 ... ok 34/126 ... ok 93/127 ... repository is empty 2/128 ... ok 68/130 ... repository is empty 99/131 ... ok 99/132 ... ok 39/133 ... ok 77/134 ... ok 43/135 ... ok 2/136 ... ok 67/138 ... ok 112/139 ... repository is empty 43/140 ... ok 43/142 ... ok 67/144 ... ok 2/145 ... ok 68/146 ... ok 60/147 ... ok 67/148 ... ok 52/149 ... ok 3/150 ... ok 3/151 ... ok 52/152 ... ok 68/153 ... repository is empty Running /opt/gitlab/embedded/service/gitlab-shell/bin/check Check GitLab API access: OK Redis available via internal API: OK
Access to /var/opt/gitlab/.ssh/authorized_keys: OK gitlab-shell self-check successful
Checking GitLab Shell ... Finished
Checking Sidekiq ...
Running? ... yes Number of Sidekiq processes ... 1
Checking Sidekiq ... Finished
Checking Reply by email ...
IMAP server credentials are correct? ... yes Init.d configured correctly? ... skipped MailRoom running? ... skipped
Checking Reply by email ... Finished
Checking LDAP ...
Server: ldapmain not verifying SSL hostname of LDAPS server ':636' LDAP authentication... Success LDAP users with access to your GitLab server (only showing the first 100 results)
Checking LDAP ... Finished
Checking GitLab ...
Git configured correctly? ... yes Database config exists? ... yes All migrations up? ... yes Database contains orphaned GroupMembers? ... no GitLab config exists? ... yes GitLab config up to date? ... yes Log directory writable? ... yes Tmp directory writable? ... yes Uploads directory exists? ... yes Uploads directory has correct permissions? ... yes Uploads directory tmp has correct permissions? ... yes Init script exists? ... skipped (omnibus-gitlab has no init script) Init script up-to-date? ... skipped (omnibus-gitlab has no init script) Projects have namespace: ... 7/1 ... yes 7/2 ... yes 7/3 ... yes 7/4 ... yes 68/5 ... yes 7/6 ... yes 6/7 ... yes 6/8 ... yes 10/9 ... yes 9/10 ... yes 19/11 ... yes 114/13 ... yes 13/14 ... yes 39/15 ... yes 6/16 ... yes 6/17 ... yes 2/18 ... yes 19/21 ... yes 7/22 ... yes 100/23 ... yes 100/24 ... yes 100/25 ... yes 100/26 ... yes 100/27 ... yes 99/28 ... yes 100/29 ... yes 100/30 ... yes 21/31 ... yes 21/32 ... yes 21/33 ... yes 6/34 ... yes 6/35 ... yes 24/36 ... yes 21/37 ... yes 20/38 ... yes 23/39 ... yes 23/40 ... yes 2/43 ... yes 2/44 ... yes 10/45 ... yes 2/46 ... yes 12/47 ... yes 25/48 ... yes 25/49 ... yes 26/50 ... yes 26/51 ... yes 6/52 ... yes 2/53 ... yes 2/54 ... yes 34/56 ... yes 38/58 ... yes 39/59 ... yes 34/63 ... yes 37/64 ... yes 49/66 ... yes 2/67 ... yes 7/68 ... yes 12/69 ... yes 51/70 ... yes 51/71 ... yes 34/72 ... yes 6/73 ... yes 4/76 ... yes 60/78 ... yes 6/79 ... yes 39/80 ... yes 2/81 ... yes 62/82 ... yes 26/83 ... yes 51/84 ... yes 96/85 ... yes 62/86 ... yes 43/87 ... yes 60/88 ... yes 64/89 ... yes 8/90 ... yes 8/92 ... yes 8/93 ... yes 24/94 ... yes 54/95 ... yes 15/96 ... yes 96/97 ... yes 60/99 ... yes 99/102 ... yes 62/103 ... yes 60/105 ... yes 60/106 ... yes 39/107 ... yes 57/108 ... yes 77/109 ... yes 99/110 ... yes 43/112 ... yes 43/113 ... yes 84/115 ... yes 81/116 ... yes 88/119 ... yes 88/120 ... yes 24/121 ... yes 24/122 ... yes 77/123 ... yes 14/124 ... yes 39/125 ... yes 34/126 ... yes 93/127 ... yes 2/128 ... yes 68/130 ... yes 99/131 ... yes 99/132 ... yes 39/133 ... yes 77/134 ... yes 43/135 ... yes 2/136 ... yes 67/138 ... yes 112/139 ... yes 43/140 ... yes 43/142 ... yes 67/144 ... yes 2/145 ... yes 68/146 ... yes 60/147 ... yes 67/148 ... yes 52/149 ... yes 3/150 ... yes 3/151 ... yes 52/152 ... yes 68/153 ... yes Redis version >= 2.8.0? ... yes Ruby version >= 2.3.5 ? ... yes (2.4.4) Git version >= 2.9.5 ? ... yes (2.17.1) Git user has default SSH configuration? ... yes Active users: ... 57 Elasticsearch version 5.1 - 5.5? ... skipped (elasticsearch is disabled)
Checking GitLab ... Finished