[Rails5.1] Update functional specs to use new keyword format
The current way of passing arguments in specs has been deprecated and will be removed in rails5.1
Deprecated style:
get :show, { id: 1 }, nil, { notice: "This is a flash message" }
New keyword style:
get :show, params: { id: 1 }, flash: { notice: "This is a flash message" },
session: nil # Can safely be omitted.
(called from block (4 levels) in <main> at /storage/projects/gitlab/gdk-ce/gitlab/spec/controllers/admin/users_controller_spec.rb:262)
DEPRECATION WARNING: Using positional arguments in functional tests has been deprecated,
in favor of keyword arguments, and will be removed in Rails 5.1.
We should update all specs to use new style.
There are at least two ways to do this quickly: