Skip to content

"About this feature" link should open in new window

Summary

When clicking on an "About this feature" link in the interface, the resulting documentation loads in the same window, leaving the current page and potentially losing any entered data.

Steps to reproduce

  1. Create a new merge request
  2. Enter information such as title, description, etc.
  3. Click the "About this feature" link next to the squash option

Example Project

No need for a specific project, this is a core feature.

What is the current bug behavior?

Documentation opens in the same window/tab that you're editing the merge request in, losing any changes you made.

What is the expected correct behavior?

Documentation should open in a new window or in some sort of modal dialog, preserving any data entered into the page previously.

Relevant logs and/or screenshots

image

Output of checks

This bug happens on gitlab.com as well as hosted installs.

Results of GitLab environment info

Expand for output related to GitLab environment info 
System information
System:
Current User:	git
Using RVM:	no
Ruby Version:	2.4.5p335
Gem Version:	2.7.6
Bundler Version:1.16.6
Rake Version:	12.3.1
Redis Version:	3.2.12
Git Version:	2.18.1
Sidekiq Version:5.2.1
Go Version:	unknown


GitLab information
Version:	11.5.3
Revision:	aa11737
Directory:	/opt/gitlab/embedded/service/gitlab-rails
DB Adapter:	postgresql
URL:		https://gitlab.example.com
HTTP Clone URL:	https://gitlab.example.com/some-group/some-project.git
SSH Clone URL:	git@gitlab.example.com:some-group/some-project.git
Using LDAP:	no
Using Omniauth:	yes
Omniauth Providers:


GitLab Shell
Version:	8.4.1
Repository storage paths:
  • default: /var/opt/gitlab/git-data/repositories Hooks: /opt/gitlab/embedded/service/gitlab-shell/hooks Git: /opt/gitlab/embedded/bin/git

Results of GitLab application Check

Expand for output related to the GitLab application check 
Checking GitLab Shell ...


GitLab Shell version >= 8.4.1 ? ... OK (8.4.1)
hooks directories in repos are links: ...
5/2 ... ok
2/3 ... ok
2/4 ... ok
2/5 ... ok
2/6 ... ok
2/7 ... ok
6/13 ... ok
6/14 ... ok
6/15 ... ok
7/16 ... ok
6/17 ... ok
6/18 ... ok
6/19 ... ok
2/20 ... ok
6/21 ... ok
3/22 ... repository is empty
7/23 ... ok
7/24 ... ok
10/25 ... ok
10/26 ... ok
10/28 ... ok
10/29 ... ok
10/30 ... ok
10/31 ... ok
10/32 ... ok
6/33 ... ok
10/34 ... ok
10/35 ... ok
3/36 ... repository is empty
3/37 ... ok
10/38 ... repository is empty
10/39 ... ok
10/40 ... ok
14/41 ... ok
14/42 ... ok
14/43 ... ok
6/44 ... ok
10/45 ... ok
15/46 ... ok
15/47 ... repository is empty
16/48 ... ok
6/49 ... ok
15/50 ... ok
16/51 ... ok
6/52 ... ok
16/53 ... ok
16/54 ... ok
16/55 ... ok
16/56 ... repository is empty
18/58 ... ok
18/59 ... ok
18/60 ... ok
20/61 ... ok
20/62 ... ok
Running /opt/gitlab/embedded/service/gitlab-shell/bin/check
Check GitLab API access: OK
Redis available via internal API: OK


Access to /var/opt/gitlab/.ssh/authorized_keys: OK
gitlab-shell self-check successful


Checking GitLab Shell ... Finished


Checking Gitaly ...


default ... OK


Checking Gitaly ... Finished


Checking Sidekiq ...


Running? ... yes
Number of Sidekiq processes ... 1


Checking Sidekiq ... Finished


Reply by email is disabled in config/gitlab.yml
Checking LDAP ...


LDAP is disabled in config/gitlab.yml


Checking LDAP ... Finished


Checking GitLab ...


Git configured correctly? ... yes
Database config exists? ... yes
All migrations up? ... yes
Database contains orphaned GroupMembers? ... no
GitLab config exists? ... yes
GitLab config up to date? ... yes
Log directory writable? ... yes
Tmp directory writable? ... yes
Uploads directory exists? ... yes
Uploads directory has correct permissions? ... yes
Uploads directory tmp has correct permissions? ... yes
Init script exists? ... skipped (omnibus-gitlab has no init script)
Init script up-to-date? ... skipped (omnibus-gitlab has no init script)
Projects have namespace: ...
5/2 ... yes
2/3 ... yes
2/4 ... yes
2/5 ... yes
2/6 ... yes
2/7 ... yes
6/13 ... yes
6/14 ... yes
6/15 ... yes
7/16 ... yes
6/17 ... yes
6/18 ... yes
6/19 ... yes
2/20 ... yes
6/21 ... yes
3/22 ... yes
7/23 ... yes
7/24 ... yes
10/25 ... yes
10/26 ... yes
10/28 ... yes
10/29 ... yes
10/30 ... yes
10/31 ... yes
10/32 ... yes
6/33 ... yes
10/34 ... yes
10/35 ... yes
3/36 ... yes
3/37 ... yes
10/38 ... yes
10/39 ... yes
10/40 ... yes
14/41 ... yes
14/42 ... yes
14/43 ... yes
6/44 ... yes
10/45 ... yes
15/46 ... yes
15/47 ... yes
16/48 ... yes
6/49 ... yes
15/50 ... yes
16/51 ... yes
6/52 ... yes
16/53 ... yes
16/54 ... yes
16/55 ... yes
16/56 ... yes
18/58 ... yes
18/59 ... yes
18/60 ... yes
20/61 ... yes
20/62 ... yes
Redis version >= 2.8.0? ... yes
Ruby version >= 2.3.5 ? ... yes (2.4.5)
Git version >= 2.9.5 ? ... yes (2.18.1)
Git user has default SSH configuration? ... yes
Active users: ... 7


Checking GitLab ... Finished

Possible fixes

I'm not familiar enough with the code to know where to look for this. However, this can be as easy as adding a target="_blank" argument to the href for that link.