Should we call wait_for_requests in the select2 helper?
The following discussion from !24684 (merged) should be addressed:
-
@nick.thomas started a discussion: (+1 comment) I was wondering if it might be better to put this inside the
select2
helper itself, as this is a surprising thing to have to do, but I don't know if that might break expectations in some other specs. WDYT?
A possible race exists between calling visit
and select2
in Rails feature specs. My theory is that in some cases, the content of the select box is populated by JS on the page. So in the spec, we load the page and call select2
to choose a particular value. JS on the page finishes executing and overwrites that value.
I fixed it in one spec by adding wait_for_requests
before the call to select2
, but I wonder if we should do that unconditionally as the first action in the select2
helper?