[Review Apps] Some merge-related tests fail in review-qa jobs but not in package-and-qa
review-qa-*
jobs:
- https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/158118980
- https://gitlab.com/gitlab-org/gitlab-ce/-/jobs/158092098
package-and-qa
jobs:
- https://gitlab.com/gitlab-org/gitlab-qa/-/jobs/158122507
- https://gitlab.com/gitlab-org/gitlab-qa/-/jobs/158122509
1) creates a merge request user creates a new merge request
Failure/Error: expect(page).to have_content('This is a merge request')
expected to find text "This is a merge request" in "500 Whoops, something went wrong on our end. Try refreshing the page, or going back and attempting the action again. Please contact your GitLab administrator if this problem persists. Go back"
# ./qa/specs/features/browser_ui/3_create/merge_request/create_merge_request_spec.rb:66:in `block (2 levels) in <module:QA>'
If I reproduce the tests manually I see the same failure. Logs show:
I ==> /var/log/gitlab/production.log <==
I Started POST "/gitlab-qa-sandbox-group/qa-test-2019-02-07-19-52-49/project-with-merge-request-88b18c9521925cc1/merge_requests" for 70.32.0.141 at 2019-02-07 20:21:19 +0000
I Processing by Projects::MergeRequests::CreationsController#create as HTML
I Parameters: {"utf8"=>"✓", "authenticity_token"=>"[FILTERED]", "merge_request"=>{"title"=>"This is a test commit", "description"=>"asf", "assignee_id"=>"", "label_ids"=>[""], "force_remove_source_branch"=>"0", "squash"=>"0", "lock_version"=>"", "source_project_id"=>"43", "source_branch"=>"qa-test-feature-6112a52464ecdaff", "target_project_id"=>"43", "target_branch"=>"master"}, "namespace_id"=>"gitlab-qa-sandbox-group/qa-test-2019-02-07-19-52-49", "project_id"=>"project-with-merge-request-88b18c9521925cc1"}
I {"format":"html","method":"POST","username":"root","path":"/gitlab-qa-sandbox-group/qa-test-2019-02-07-19-52-49/project-with-merge-request-88b18c9521925cc1/merge_requests","duration":382.3,"correlation_id":"MFXLNnVYXz1","db":72.57,"error":"ArgumentError: wrong number of arguments (given 1, expected …
I Completed 500 Internal Server Error in 381ms (ActiveRecord: 72.6ms)
I ==> /var/log/gitlab/production_json.log <==
I
I ==> /var/log/gitlab/production.log <==
I
I ArgumentError (wrong number of arguments (given 1, expected 0)):
I app/services/ci/create_pipeline_service.rb:111:in `extra_options'
I app/services/ci/create_pipeline_service.rb:39:in `execute'
I app/services/merge_requests/base_service.rb:70:in `create_merge_request_pipeline'
I lib/gitlab/metrics/instrumentation.rb:161:in `block in create_merge_request_pipeline'
I lib/gitlab/metrics/method_call.rb:36:in `measure'
I lib/gitlab/metrics/instrumentation.rb:161:in `create_merge_request_pipeline'
I app/services/merge_requests/create_service.rb:28:in `after_create'
I lib/gitlab/metrics/instrumentation.rb:161:in `block in after_create'
I lib/gitlab/metrics/method_call.rb:36:in `measure'
I lib/gitlab/metrics/instrumentation.rb:161:in `after_create'
I app/services/issuable_base_service.rb:159:in `create'
I app/services/merge_requests/create_service.rb:37:in `create'
I lib/gitlab/metrics/instrumentation.rb:161:in `block in create'
I lib/gitlab/metrics/method_call.rb:36:in `measure'
I lib/gitlab/metrics/instrumentation.rb:161:in `create'
I app/services/merge_requests/create_service.rb:14:in `execute'
I lib/gitlab/metrics/instrumentation.rb:161:in `block in execute'
I lib/gitlab/metrics/method_call.rb:36:in `measure'
I lib/gitlab/metrics/instrumentation.rb:161:in `execute'
I app/controllers/projects/merge_requests/creations_controller.rb:23:in `create'
I lib/gitlab/i18n.rb:55:in `with_locale'
I lib/gitlab/i18n.rb:61:in `with_user_locale'
I app/controllers/application_controller.rb:423:in `set_locale'
I lib/gitlab/middleware/rails_queue_duration.rb:24:in `call'
I lib/gitlab/metrics/rack_middleware.rb:17:in `block in call'
I lib/gitlab/metrics/transaction.rb:55:in `run'
I lib/gitlab/metrics/rack_middleware.rb:17:in `call'
I lib/gitlab/middleware/multipart.rb:103:in `call'
I lib/gitlab/request_profiler/middleware.rb:16:in `call'
I lib/gitlab/middleware/go.rb:20:in `call'
I lib/gitlab/etag_caching/middleware.rb:13:in `call'
I lib/gitlab/middleware/correlation_id.rb:16:in `block in call'
I lib/gitlab/correlation_id.rb:15:in `use_id'
I lib/gitlab/middleware/correlation_id.rb:15:in `call'
I lib/gitlab/middleware/read_only/controller.rb:40:in `call'
I lib/gitlab/middleware/read_only.rb:18:in `call'
I lib/gitlab/middleware/basic_health_check.rb:25:in `call'
I lib/gitlab/request_context.rb:20:in `call'
I lib/gitlab/metrics/requests_rack_middleware.rb:29:in `call'
I lib/gitlab/middleware/release_env.rb:13:in `call'
(is there an easy way to copy just the text of the logs? That was painful).
More logs: logs__2019-02-07T03-21.json
Other failures:
2) Create Merge request rebasing user rebases source branch of merge request
Failure/Error: expect(merge_request).not_to be_fast_forward_possible
expected `#<QA::Page::MergeRequest::Show:0x000055a5ce32baf8>.fast_forward_possible?` to return false, got true
# ./qa/specs/features/browser_ui/3_create/merge_request/rebase_merge_request_spec.rb:35:in `block (4 levels) in <module:QA>'
# ./qa/scenario/actable.rb:14:in `perform'
# ./qa/specs/features/browser_ui/3_create/merge_request/rebase_merge_request_spec.rb:33:in `block (3 levels) in <module:QA>'
3) Create Merge request creation user creates a new merge request
Failure/Error: expect(merge_request).to have_content('This is a merge request with a milestone')
expected to find text "This is a merge request with a milestone" in "500 Whoops, something went wrong on our end. Try refreshing the page, or going back and attempting the action again. Please contact your GitLab administrator if this problem persists. Go back"
# ./qa/specs/features/browser_ui/3_create/merge_request/create_merge_request_spec.rb:37:in `block (4 levels) in <module:QA>'
# ./qa/scenario/actable.rb:14:in `perform'
# ./qa/specs/features/browser_ui/3_create/merge_request/create_merge_request_spec.rb:36:in `block (3 levels) in <module:QA>'
4) Create Merge request creation from fork user forks a project, submits a merge request and maintainer merges it
Failure/Error: Page::Main::Menu.perform(&:sign_out)
Capybara::ElementNotFound:
Unable to find visible css ".qa-navbar"
# /usr/local/bundle/gems/capybara-2.16.1/lib/capybara/node/finders.rb:314:in `block in synced_resolve'
# /usr/local/bundle/gems/capybara-2.16.1/lib/capybara/node/base.rb:85:in `synchronize'
# /usr/local/bundle/gems/capybara-2.16.1/lib/capybara/node/finders.rb:302:in `synced_resolve'
# /usr/local/bundle/gems/capybara-2.16.1/lib/capybara/node/finders.rb:37:in `find'
# /usr/local/bundle/gems/capybara-2.16.1/lib/capybara/session.rb:810:in `block (2 levels) in <class:Session>'
# /usr/local/bundle/gems/capybara-2.16.1/lib/capybara/session.rb:340:in `within'
# ./qa/page/main/menu.rb:80:in `within_top_menu'
# ./qa/page/main/menu.rb:86:in `within_user_menu'
# ./qa/page/main/menu.rb:54:in `sign_out'
# ./qa/scenario/actable.rb:14:in `perform'
# ./qa/specs/features/browser_ui/3_create/merge_request/merge_merge_request_from_fork_spec.rb:14:in `block (3 levels) in <module:QA>'
/cc @rymai