Broken master: spec/migrations/schedule_runners_token_encryption_spec.rb
Spotted in EE, but I wonder if it's order-dependent and breaks on CE in some circumstances too: https://gitlab.com/gitlab-org/gitlab-ee/-/jobs/190624547
Failure:
Failures:
1) ScheduleRunnersTokenEncryption schedules runners token encryption migration for multiple resources
Failure/Error: expect(BackgroundMigrationWorker.jobs.size).to eq 7
expected: 7
got: 30
(compared using ==)
# ./spec/migrations/schedule_runners_token_encryption_spec.rb:34:in `block (4 levels) in <top (required)>'
# ./spec/migrations/schedule_runners_token_encryption_spec.rb:24:in `block (3 levels) in <top (required)>'
# ./spec/migrations/schedule_runners_token_encryption_spec.rb:23:in `block (2 levels) in <top (required)>'
Finished in 18 minutes 49 seconds (files took 16.78 seconds to load)
987 examples, 1 failure, 3 pending
Failed examples:
rspec ./spec/migrations/schedule_runners_token_encryption_spec.rb:22 # ScheduleRunnersTokenEncryption schedules runners token encryption migration for multiple resources
Spec files that ran, in order:
"spec/features/issues/user_interacts_with_awards_spec.rb": 107.5682201385498,
"spec/features/issues/user_creates_branch_and_merge_request_spec.rb": 91.84243822097778,
"spec/features/projects/commits/user_browses_commits_spec.rb": 81.70160222053528,
"spec/models/clusters/applications/ingress_spec.rb": 44.38644623756409,
"spec/features/reportable_note/merge_request_spec.rb": 63.605053424835205,
"spec/features/projects/settings/user_manages_merge_requests_settings_spec.rb": 52.61974549293518,
"spec/features/merge_request/user_views_diffs_spec.rb": 45.589001178741455,
"spec/models/concerns/issuable_spec.rb": 39.04491829872131,
"spec/controllers/groups/clusters_controller_spec.rb": 27.331557273864746,
"spec/features/security/profile_access_spec.rb": 50.024513721466064,
"spec/features/projects/services/user_activates_slack_slash_command_spec.rb": 27.355334281921387,
"spec/lib/banzai/filter/relative_link_filter_spec.rb": 20.812724590301514,
"spec/requests/api/pages/private_access_spec.rb": 16.118263244628906,
"spec/features/projects/jobs/user_browses_job_spec.rb": 26.15900444984436,
"spec/services/projects/move_forks_service_spec.rb": 14.184605360031128,
"spec/requests/api/internal_spec.rb": 13.275754690170288,
"spec/models/concerns/avatarable_spec.rb": 11.828239917755127,
"spec/lib/gitlab/background_migration/prepare_untracked_uploads_spec.rb": 12.52042007446289,
"spec/workers/concerns/waitable_worker_spec.rb": 10.089433193206787,
"spec/finders/merge_request_target_project_finder_spec.rb": 9.835164546966553,
"spec/controllers/projects/services_controller_spec.rb": 8.344505786895752,
"spec/features/dashboard/datetime_on_tooltips_spec.rb": 10.772643089294434,
"spec/requests/api/group_boards_spec.rb": 6.364333868026733,
"spec/services/issuable/common_system_notes_service_spec.rb": 7.753826379776001,
"spec/views/layouts/nav/sidebar/_project.html.haml_spec.rb": 8.866421937942505,
"spec/lib/gitlab/gitaly_client/repository_service_spec.rb": 5.73393988609314,
"spec/policies/ci/trigger_policy_spec.rb": 5.421483755111694,
"spec/features/read_only_spec.rb": 8.407968521118164,
"spec/lib/gitlab/import_export/after_export_strategies/base_after_export_strategy_spec.rb": 4.695170164108276,
"spec/services/search/global_service_spec.rb": 4.314560651779175,
"spec/features/ics/project_issues_spec.rb": 4.711593866348267,
"spec/lib/extracts_path_spec.rb": 4.44577693939209,
"spec/finders/cluster_ancestors_finder_spec.rb": 1.9985506534576416,
"spec/services/clusters/applications/update_service_spec.rb": 3.031369209289551,
"spec/graphql/resolvers/issues_resolver_spec.rb": 3.597498655319214,
"spec/models/network/graph_spec.rb": 2.514853000640869,
"spec/requests/api/project_snapshots_spec.rb": 1.2505521774291992,
"spec/services/ci/run_scheduled_build_service_spec.rb": 2.223207473754883,
"spec/requests/api/graphql_spec.rb": 5.029788017272949,
"spec/lib/banzai/reference_parser/label_parser_spec.rb": 2.578990936279297,
"spec/migrations/schedule_sync_issuables_state_id_spec.rb": 2.0075843334198,
"spec/lib/banzai/pipeline/full_pipeline_spec.rb": 1.5919620990753174,
"spec/views/projects/environments/terminal.html.haml_spec.rb": 1.6155571937561035,
"spec/models/blob_viewer/readme_spec.rb": 1.3526489734649658,
"spec/services/ci/archive_trace_service_spec.rb": 1.3470447063446045,
"spec/services/boards/visits/latest_service_spec.rb": 1.2961657047271729,
"spec/controllers/projects/settings/repository_controller_spec.rb": 1.3690438270568848,
"spec/services/projects/hashed_storage/rollback_service_spec.rb": 1.246309518814087,
"spec/workers/update_merge_requests_worker_spec.rb": 0.8899168968200684,
"spec/finders/pipeline_schedules_finder_spec.rb": 0.9528355598449707,
"spec/migrations/schedule_runners_token_encryption_spec.rb": 3.7710301876068115,