New dataraces introduced
Job #583788702 failed for 8648f680:
=== RUN TestNewReadLogsCommandFileLogStreamProviderCorrect
==================
WARNING: DATA RACE
Read at 0x00c000032160 by goroutine 28:
gitlab.com/gitlab-org/gitlab-runner/commands/helpers.TestNewReadLogsCommandFileLogStreamProviderCorrect()
/builds/gitlab-org/gitlab-runner/commands/helpers/read_logs_test.go:78 +0x3c1
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
Previous write at 0x00c000032160 by goroutine 29:
gitlab.com/gitlab-org/gitlab-runner/commands/helpers.(*ReadLogsCommand).Execute()
/builds/gitlab-org/gitlab-runner/commands/helpers/read_logs.go:94 +0x12e
Goroutine 28 (running) created at:
testing.(*T).Run()
/usr/local/go/src/testing/testing.go:960 +0x651
testing.runTests.func1()
/usr/local/go/src/testing/testing.go:1202 +0xa6
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
testing.runTests()
/usr/local/go/src/testing/testing.go:1200 +0x521
testing.(*M).Run()
/usr/local/go/src/testing/testing.go:1117 +0x2ff
main.main()
_testmain.go:222 +0x337
Goroutine 29 (running) created at:
gitlab.com/gitlab-org/gitlab-runner/commands/helpers.TestNewReadLogsCommandFileLogStreamProviderCorrect()
/builds/gitlab-org/gitlab-runner/commands/helpers/read_logs_test.go:72 +0x2cb
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
==================
==================
WARNING: DATA RACE
Read at 0x00c00000e0e0 by goroutine 28:
reflect.typedmemmove()
/usr/local/go/src/runtime/mbarrier.go:177 +0x0
reflect.packEface()
/usr/local/go/src/reflect/value.go:119 +0x103
reflect.valueInterface()
/usr/local/go/src/reflect/value.go:1033 +0x16f
reflect.deepValueEqual()
/usr/local/go/src/reflect/deepequal.go:132 +0xa95
reflect.deepValueEqual()
/usr/local/go/src/reflect/deepequal.go:101 +0xc50
reflect.deepValueEqual()
/usr/local/go/src/reflect/deepequal.go:98 +0x1835
reflect.DeepEqual()
/usr/local/go/src/reflect/deepequal.go:196 +0x2ed
github.com/stretchr/testify/assert.ObjectsAreEqual()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/assert/assertions.go:64 +0x23b
github.com/stretchr/testify/assert.Equal()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/assert/assertions.go:342 +0x257
gitlab.com/gitlab-org/gitlab-runner/commands/helpers.TestNewReadLogsCommandFileLogStreamProviderCorrect()
/builds/gitlab-org/gitlab-runner/commands/helpers/read_logs_test.go:75 +0x427
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
Previous write at 0x00c00000e0e0 by goroutine 29:
gitlab.com/gitlab-org/gitlab-runner/commands/helpers.(*ReadLogsCommand).Execute()
/builds/gitlab-org/gitlab-runner/commands/helpers/read_logs.go:95 +0xa7
Goroutine 28 (running) created at:
testing.(*T).Run()
/usr/local/go/src/testing/testing.go:960 +0x651
testing.runTests.func1()
/usr/local/go/src/testing/testing.go:1202 +0xa6
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
testing.runTests()
/usr/local/go/src/testing/testing.go:1200 +0x521
testing.(*M).Run()
/usr/local/go/src/testing/testing.go:1117 +0x2ff
main.main()
_testmain.go:222 +0x337
Goroutine 29 (running) created at:
gitlab.com/gitlab-org/gitlab-runner/commands/helpers.TestNewReadLogsCommandFileLogStreamProviderCorrect()
/builds/gitlab-org/gitlab-runner/commands/helpers/read_logs_test.go:72 +0x2cb
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
==================
==================
WARNING: DATA RACE
Read at 0x00c00000e0e8 by goroutine 28:
reflect.typedmemmove()
/usr/local/go/src/runtime/mbarrier.go:177 +0x0
reflect.packEface()
/usr/local/go/src/reflect/value.go:119 +0x103
reflect.valueInterface()
/usr/local/go/src/reflect/value.go:1033 +0x16f
reflect.deepValueEqual()
/usr/local/go/src/reflect/deepequal.go:132 +0xa95
reflect.deepValueEqual()
/usr/local/go/src/reflect/deepequal.go:101 +0xc50
reflect.deepValueEqual()
/usr/local/go/src/reflect/deepequal.go:98 +0x1835
reflect.DeepEqual()
/usr/local/go/src/reflect/deepequal.go:196 +0x2ed
github.com/stretchr/testify/assert.ObjectsAreEqual()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/assert/assertions.go:64 +0x23b
github.com/stretchr/testify/assert.Equal()
/go/pkg/mod/github.com/stretchr/testify@v1.4.0/assert/assertions.go:342 +0x257
gitlab.com/gitlab-org/gitlab-runner/commands/helpers.TestNewReadLogsCommandFileLogStreamProviderCorrect()
/builds/gitlab-org/gitlab-runner/commands/helpers/read_logs_test.go:75 +0x427
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
Previous write at 0x00c00000e0e8 by goroutine 29:
gitlab.com/gitlab-org/gitlab-runner/commands/helpers.(*ReadLogsCommand).Execute()
/builds/gitlab-org/gitlab-runner/commands/helpers/read_logs.go:96 +0xf5
Goroutine 28 (running) created at:
testing.(*T).Run()
/usr/local/go/src/testing/testing.go:960 +0x651
testing.runTests.func1()
/usr/local/go/src/testing/testing.go:1202 +0xa6
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
testing.runTests()
/usr/local/go/src/testing/testing.go:1200 +0x521
testing.(*M).Run()
/usr/local/go/src/testing/testing.go:1117 +0x2ff
main.main()
_testmain.go:222 +0x337
Goroutine 29 (running) created at:
gitlab.com/gitlab-org/gitlab-runner/commands/helpers.TestNewReadLogsCommandFileLogStreamProviderCorrect()
/builds/gitlab-org/gitlab-runner/commands/helpers/read_logs_test.go:72 +0x2cb
testing.tRunner()
/usr/local/go/src/testing/testing.go:909 +0x199
==================
--- FAIL: TestNewReadLogsCommandFileLogStreamProviderCorrect (1.00s)
testing.go:853: race detected during execution of test
This test was introduced in !2038 (merged)
Edited by Steve Xuereb