Update error message in Docker executor
We should update the log entry in http://gitlab.com/gitlab-org/gitlab-runner/blob/fe72ecd774dc9c5e7188de42c81ab447a17fbf9f/executors/docker/docker.go#L805 to be more readable.
For an image called missing
, it currently outputs
ERROR: The missing is not present on list of allowed images
- image1
- image2
Proposal
-
Change the log format to:
e.Errorln(fmt.Sprintf("The %q image is not present on list of allowed %s:", image, optionName))
With this change, the message would instead be:
ERROR: The "missing" image is not present on list of allowed images:
- image1
- image2
Original discussion.
Edited by Pedro Pombeiro