Windows tests: failed to call git rev-parse exit status 128
We're occasionally seeing the error failed to call git rev-parse --git-common-dir: exit status 128
in our Windows tests.
This error message comes from git-lfs
, and is a result of git rev-parse
failing for some reason, but git-lfs
doesn't pass along the reason, but will do soon: https://github.com/git-lfs/git-lfs/commit/a1e86326c4c07cf13d24c624122974ac8240e021. I cannot replicate the failure locally.
The latest version of git-lfs
is currently 3.2.0
and doesn't have the above change. Once >= 3.3.0
is out, we'll likely discover the true reason. In the mean time, I'm going to skip the use of git-lfs
in tests where we can, commenting to this issue as to why.