Update GitLab CI image to include git lfs
Summary
When trying to build dockerfiles/ci/Dockerfile
which is the container that is used to run our unit test, the build fails. If we look closely at the error golang.org/x/tools/go/internal/packagesdriver/sizes.go:94: undefined: types.SizesFor
this is because we are pulling the library that does not support version 1.8
This base image is used for all our CI, it doesn't change much but then next time we want to change it we can't do much. We can version pin the library to a specific version but that is not ideal and fragile
We need to update our go version in #3202 (closed) so that we can update the base image.
Relevant logs and/or screenshots
Cleanup
After the issue is resolved, following changes should be cleaned and moved to the CI Docker images:
-
!1200 (merged) - installation of Git LFS for the tests environment (https://gitlab.com/gitlab-org/gitlab-runner/blob/3366-temporary-fix-for-lfs-clone-failure/.gitlab-ci.yml#L225-232)
Edited by Pedro Pombeiro