Support Windows 1903 (May 2019 Release) for Windows Docker Executor
Description
A new version of Windows has been released 1903, for windows server & windows 10 now since we have hard-coded windows server version supported, the user would end up having problems like below:
Running with gitlab-runner 11.11.2 (ac2a293c)
on dev-windows (a virtual windows 10 machine called BT1-VM-WIN10-Gitlab71 on vSphere) 7PhLzoGk
ERROR: Preparation failed: could not determine windows version
Will be retried in 3s ...
ERROR: Preparation failed: could not determine windows version
Will be retried in 3s ...
ERROR: Preparation failed: could not determine windows version
Will be retried in 3s ...
ERROR: Job failed (system failure): could not determine windows version
Windows 1903 is a semi-annual release channel
Proposal
12.10
-
Update the supported Windows versions 👉 !1984 (merged)
13.1
We need to follow the process below:
-
Publish 1903 based helper image -
Create a new VM with windows 1903 installed so that we can build docker containers on 1903. For this, we can use the Windows Shared Runners MVC since those are based on 1903. -
Create a base image gitlab-org/ci-cd/shared-runners/images/gcp/windows-containers!9 (merged) -
Set up a project/group runner that will use the 1903 image. https://gitlab.com/gitlab-com/gl-infra/infrastructure/-/issues/9468
-
-
Create a new Dockerfile based in windows server core 1903, which is already available on docker hub -
Start building and publish windows 1903 helper image, for development, bleeding, stable (!1634 (merged))
-
-
Run test pipelines in 1903 (!1634 (merged))
Merge requests
Links to related issues and merge requests / references
Originally reported by @janwilmans in b3b26bcc (comment 185223862)
Dev Log
2020-03-11
- Update gitlab-org/ci-cd/shared-runners/images/gcp/windows-containers!9 (merged) to use the latest version
- Create gitlab-org/ci-cd/shared-runners/images/gcp/windows-containers!20 (merged) to upgrade the chef client version since the current version leads to a 503 https://gitlab.com/gitlab-org/ci-cd/shared-runners/images/gcp/windows-containers/-/jobs/467192016
2020-03-16
- Update gitlab-org/ci-cd/shared-runners/images/gcp/windows-containers!9 (merged) ready for review
- Start investigating https://gitlab.com/gitlab-com/gl-infra/infrastructure/-/issues/9468
2020-04-20
- Get gitlab-org/ci-cd/shared-runners/images/gcp/windows-containers!9 (merged) ready for review
- Start working on https://gitlab.com/gitlab-com/gl-infra/infrastructure/-/issues/9468 ansible changes
2020-04-21
- Open WIP merge request to add 1903/1909 Window machines https://ops.gitlab.net/gitlab-com/gl-infra/ci-infrastructure-windows/-/merge_requests/60
Edited by Darren Eastman